Re: 61-gary-refactor-shell-variable-promulgation.patch

[Gary V. Vaughan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bob Friesenhahn wrote:
| On Tue, 6 Jan 2004, Gary V. Vaughan wrote:
|
|
|>-----BEGIN PGP SIGNED MESSAGE-----
|>Hash: SHA1
|>
|>Okay to commit?
|>
|>Saying `no' is not an option... it has taken me about 2 weeks of evening
|>hacking time to beat this sucker into shape. :-b
|
|
| We can hardly be expected to inspect a 300K+ patch and provide a 'yes'
| or 'no' answer.  I would say 'no' as a matter of principle
| (uninspected patches would not make it into the Mars Lander), but
| since that is not an option then the answer must be 'yes', and any
| flaws detected will be repaired later as usual.

Did you miss a smiley?  Luckily, we won't lose touch with our lander if the
patch crashes... oh wait, we're still on savannah... maybe there'll be another
communication window next week :-)

The diff hasn't come out very well for this patch, the changes are no where
near as pervasive as the 300k might suggest.  There are a bunch of new
functions, and then I have removed the hardcoded variable references from the
generation of config.status and libtool, and replaced them with declarations
in the macro that defined them.

I have spent most of today testing, and comparing the contents of
config.status and libtool pre- and post- patch.  I'm extremely confident that
there are no regressions wrt. my Linux and MacOS installations...

Cheers,
        Gary.
- --
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://www.oranda.demon.co.uk
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQE/+xnHFRMICSmD1gYRAlI7AJwMiPzbVUB6oEc/4Et0198t3r4K8wCgoIxy
ATdfJWdQvDPoiJORCZzKOAY=
=O1rK
-----END PGP SIGNATURE-----