Re: 111-gary-require-c89-compiler.patch

[Gary V. Vaughan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bob Friesenhahn wrote:
| On Fri, 2 Apr 2004, Gary V. Vaughan wrote:
|>Okay to commit?
|
|
| I would say say "yes", except that I don't believe it was wise to
| convert 'lt_ptr' to 'void *'.  Certainly they are actually the same
| type, but lt_ptr provides a level of abstraction which should not be
| removed.  Also, user code which specifies lt_ptr will break unless a
| typedef for lt_ptr continues to exist.

lt_ptr was never a typedef, it was sometimes #defined to char*.

The patch unconditionally '#define lt_ptr void *' in ltdl.h for backwards
compatibility.

As to the abstraction, I want to replace some of the newly revealed
'void *' with typedefs from a pseudo-object oriented struct stack as I
tease out the spaghetti in ltdl.c, and removing the cruft is gonna make
it a whole lot easier for us to see what the hell is going on in the
first place! :-)

There is also an outstanding compilation bug with casting between 'void *'
and function pointers in the guts of ltdl which I want to fix in due course.

Cheers,
        Gary.
- --
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAbYoVFRMICSmD1gYRApErAJ9r9+ar7KGCqeyCIRLnJOguPiuHUgCgt27o
fYC/h0NF8ABdKXnNIJigd7A=
=zmRV
-----END PGP SIGNATURE-----