Re: 114-gary-factor-argz.patch

[Ralf Wildenhues]

* Gary V. Vaughan wrote on Mon, Apr 05, 2004 at 01:16:33PM CEST:
> 
> Okay to commit?

This patch breaks on Linux/x86 (RedHat 9), at least I think it's this
one.  In m4/ltdl.m4, error_t is checked for in system's argz.h (amongst
a number of other argz features), yet nothing includes that in the
source, only $top_srcdir/libltdl/argz.h is ever included.

make[2]: Entering directory 
`/home/wildenhu/download/software/libtool/libtool/build/libltdl'
if /bin/sh ../libtool --mode=compile gcc -DHAVE_CONFIG_H="<config.h>" -DLTDL 
-I. -I../../libltdl -I..  -I.. -I../..   -g -O2 -MT ltdl.lo -MD -MP -MF 
".deps/ltdl.Tpo" -c -o ltdl.lo ../../libltdl/ltdl.c; \
then mv -f ".deps/ltdl.Tpo" ".deps/ltdl.Plo"; else rm -f ".deps/ltdl.Tpo"; exit 
1; fi
 gcc "-DHAVE_CONFIG_H=<config.h>" -DLTDL -I. -I../../libltdl -I.. -I.. -I../.. 
-g -O2 -MT ltdl.lo -MD -MP -MF .deps/ltdl.Tpo -c ../../libltdl/ltdl.c  -fPIC 
-DPIC -o .libs/ltdl.o
In file included from ../../libltdl/lt__glibc.h:52,
                 from ../../libltdl/lt__private.h:60,
                 from ../../libltdl/ltdl.c:31:
../../libltdl/argz.h:45: parse error before "lt__argz_append"
../../libltdl/argz.h:46: warning: data definition has no type or storage class
../../libltdl/argz.h:47: parse error before "lt__argz_create_sep"
../../libltdl/argz.h:48: warning: data definition has no type or storage class
../../libltdl/argz.h:49: parse error before "lt__argz_insert"
../../libltdl/argz.h:50: warning: data definition has no type or storage class
../../libltdl/ltdl.c: In function `argzize_path':
../../libltdl/ltdl.c:593: `error_t' undeclared (first use in this function)
../../libltdl/ltdl.c:593: (Each undeclared identifier is reported only once
../../libltdl/ltdl.c:593: for each function it appears in.)
../../libltdl/ltdl.c:593: parse error before "error"
../../libltdl/ltdl.c:599: `error' undeclared (first use in this function)
../../libltdl/ltdl.c: In function `foreach_dirinpath':
../../libltdl/ltdl.c:649: warning: assignment makes pointer from integer 
without a cast
../../libltdl/ltdl.c: In function `lt_argz_insert':
../../libltdl/ltdl.c:1478: `error_t' undeclared (first use in this function)
../../libltdl/ltdl.c:1478: parse error before "error"
../../libltdl/ltdl.c:1480: `error' undeclared (first use in this function)
../../libltdl/ltdl.c: In function `lt_argz_insertinorder':
../../libltdl/ltdl.c:1507: warning: assignment makes pointer from integer 
without a cast
../../libltdl/ltdl.c: In function `foreachfile_callback':
../../libltdl/ltdl.c:1633: warning: assignment makes pointer from integer 
without a cast
make[2]: *** [ltdl.lo] Error 1
make[2]: Leaving directory 
`/home/wildenhu/download/software/libtool/libtool/build/libltdl'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory 
`/home/wildenhu/download/software/libtool/libtool/build'
make: *** [all] Error 2

Regards,
Ralf