[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: match_pattern support for .a files linked in shared libs
From: |
Jacob Meuser |
Subject: |
Re: match_pattern support for .a files linked in shared libs |
Date: |
Mon, 2 Aug 2004 16:29:36 -0700 |
User-agent: |
Mutt/1.4.2i |
On Fri, Jul 30, 2004 at 09:59:17PM -0500, Albert Chin wrote:
> On Fri, Jul 30, 2004 at 10:21:53AM -0701, Jacob Meuser wrote:
> > When libtool is given a .a to link into a shared library, if
> > deplibs_check_method != pass_all, it doesn't link. However,
> > both NetBSD and OpenBSD allow shared libs to be built with
> > certain .a files, as per match_pattern.
> >
> > Here is a patch against branch-1-5.
> >
> > I ripped the match-pattern_regex from another part of libtool.
> >
> > --
> > <address@hidden>
>
> > Index: ltmain.in
> > ===================================================================
> > RCS file: /cvsroot/libtool/libtool/ltmain.in,v
> > retrieving revision 1.334.2.37
> > diff -u -r1.334.2.37 ltmain.in
> > --- ltmain.in 30 Jul 2004 14:02:12 -0000 1.334.2.37
> > +++ ltmain.in 30 Jul 2004 17:15:07 -0000
> > @@ -2099,7 +2099,21 @@
> > fi
> > case $linkmode in
> > lib)
> > - if test "$deplibs_check_method" != pass_all; then
> > + valid_a_lib=no
> > + case $deplibs_check_method in
> > + match_pattern*)
> > + match_pattern_regex=`expr "$deplibs_check_method" : "$2 \(.*\)"`
> > + if eval $echo \"$deplib\" 2>/dev/null \
> > + | ${SED} 10q \
> > + | ${EGREP} "$match_pattern_regex" > /dev/null; then
>
> ${SED} -> $SED
> ${EGREP} -> $EGREP
>
> And, you need to fix the indentation after the 'if' statement.
I pretty much straight cut'n pasted that, and I see the same things
both above and below the patch.
Is there a style guide?
--
<address@hidden>
- Re: match_pattern support for .a files linked in shared libs,
Jacob Meuser <=