[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libtool-1.5 pre-ANSI replacement
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] libtool-1.5 pre-ANSI replacement |
Date: |
Mon, 13 Sep 2004 15:52:14 +0200 |
User-agent: |
Mutt/1.4.1i |
Hi Gary,
* Gary V. Vaughan wrote on Mon, Sep 13, 2004 at 02:45:04PM CEST:
> Hallo Ralf,
>
> Ralf Wildenhues wrote:
> > 2004-09-08 Ralf Wildenhues <address@hidden>
> >
> > * ltdl.c (memcpy, memmove): Fix pre-ANSI replacement functions
> > to not use pointer-to-void arithmetic.
> > (memmove): Fix infinite loop.
>
> Applied, thanks.
>
> Out of curiosity, are you actually testing on a platform that uses this?
No.
> Or is it just an aesthetic issue?
Yes. Stumbled over the code by chance.
> One of the assumptions we make in the
> TRUNK is that no-one has reported that the pre-ANSI functions are broken...
> so we require an ANSI compiler.
Fine with me, mostly. I'd complain about things like malloc(0), free(0).
Regards,
Ralf