[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FYI: libtool--devo--1.0--patch-181
From: |
Ralf Wildenhues |
Subject: |
Re: FYI: libtool--devo--1.0--patch-181 |
Date: |
Wed, 29 Sep 2004 13:37:42 +0200 |
User-agent: |
Mutt/1.4.1i |
Sorry for the self-reply.
* Ralf Wildenhues wrote on Tue, Sep 28, 2004 at 11:53:07AM CEST:
> * Gary V. Vaughan wrote on Wed, Sep 15, 2004 at 03:26:15AM CEST:
>
> This patch (maybe in conjunction with patch-180) breaks libtool on
> linux-gnu with bash-2.05b.0(1). This can be seen using
> TESTS='mdemo-conf.test mdemo-make.test mdemo-inst.test'
>
> What happens? Command line option
> -export-symbols-regex "libfoo2.*"
> is not put quoted into libfoo2.la, that is, libfoo2.la contains
*snip*
> If I change the code to use the old
> | qarg=\"`$echo "X$arg" | $Xsed -e "$sed_quote_subst"`\"
> then things work again. (Of course, since the older code looked for
> meta-characters in order to quote only arguments in need of quotes,
> and this simple-minded change quotes all arguments, the created
> libfoo2.la file is still different. But it works for me.)
>
> Now I know the old code was not portable. So what would be a portable
> solution?
Might it be that the following patch fixes the problem for good?
Regards,
Ralf
2004-09-29 Ralf Wildenhues <address@hidden>
* config/ltmain.in (): Fix quoting bug. Fixes e.g. the quoting
of the -export-symbols-regex argument in .la files' relink_command.
Index: config/ltmain.in
===================================================================
RCS file: /cvsroot/libtool/libtool/config/ltmain.in,v
retrieving revision 1.32
diff -u -r1.32 ltmain.in
--- config/ltmain.in 25 Sep 2004 13:38:53 -0000 1.32
+++ config/ltmain.in 29 Sep 2004 08:49:50 -0000
@@ -2188,7 +2188,8 @@
arg="$1"
shift
qarg=`$ECHO "X$arg" | $Xsed -e "$sed_quote_subst"`
- libtool_args="$libtool_args $qarg"
+ func_quote_for_eval "$qarg"
+ libtool_args="$libtool_args $func_quote_for_eval_result"
# If the previous option needs an argument, assign it.
if test -n "$prev"; then