libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: carefully cast arguments of isspace/isalnum incase 8th bit is set [


From: Gary V. Vaughan
Subject: FYI: carefully cast arguments of isspace/isalnum incase 8th bit is set [libtool--devo--1.0--patch-218]
Date: Fri, 1 Oct 2004 10:59:17 +0100 (BST)
User-agent: mailnotify/0.3

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Applied to HEAD.

  * looking for address@hidden/libtool--devo--1.0--patch-217 to compare with
  * comparing to address@hidden/libtool--devo--1.0--patch-217
  M  ChangeLog
  M  libltdl/ltdl.c
  
  * modified files
  
  Index: Changelog
  from  Ralf Wildenhues  <address@hidden>
  
        * libltdl/ltdl.c (load_deplibs, try_dlopen): Cast argument
        to isspace/isalnum to the correct range.  Also, cast to int to
        avoid compiler warnings.
  
  --- orig/libltdl/ltdl.c
  +++ mod/libltdl/ltdl.c
  @@ -737,10 +737,10 @@
     p = deplibs;
     while (*p)
       {
  -      if (!isspace ((int) *p))
  +      if (!isspace ((int)(unsigned char) *p))
        {
          char *end = p+1;
  -       while (*end && !isspace((int) *end))
  +       while (*end && !isspace((int)(unsigned char) *end))
            {
              ++end;
            }
  @@ -786,14 +786,14 @@
     p = deplibs;
     while (*p)
       {
  -      if (isspace ((int) *p))
  +      if (isspace ((int)(unsigned char) *p))
        {
          ++p;
        }
         else
        {
          char *end = p+1;
  -       while (*end && !isspace ((int) *end))
  +       while (*end && !isspace ((int)(unsigned char) *end))
            {
              ++end;
            }
  @@ -1004,7 +1004,7 @@
       int i;
       for (i = 0; i < ext - base_name; ++i)
         {
  -     if (isalnum ((int)(base_name[i])))
  +     if (isalnum ((int)(unsigned char)(base_name[i])))
          {
            name[i] = base_name[i];
          }
  
  
  
- -- 
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook
_________________________________________________________
This patch notification generated by tlaapply version 0.6
http://tkd.kicks-ass.net/arch/address@hidden/cvs-utils--tla--1.0
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)

iD8DBQFBXSp0FRMICSmD1gYRAvITAJ96ZTtTVxdZX0RP2OOQLn4AAwS3TQCgppQb
jVXoYFJZmTQfD3hfsJY5tCs=
=7vj2
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]