Re: FYI: sh.test needs the correct path to ltmain.sh [libtool--release--2.0--patch-11]

[Bob Friesenhahn]

> Allow the line if it contains a `&'.  Just a simple-minded idea.
>
> OK to apply to branch-2-0 and HEAD?

Rather than "disabled for now." the comment should mention when it is 
expected that the code will be enabled.  If it can be enabled after 
the next autoconf release, then it is worth saying so.

Bob

> Regards,
> Ralf
>
> cvs diff: Diffing tests
> Index: tests/sh.test
> ===================================================================
> RCS file: /cvsroot/libtool/libtool/tests/sh.test,v
> retrieving revision 1.19
> diff -u -r1.19 sh.test
> --- tests/sh.test       23 Sep 2004 14:50:36 -0000      1.19
> +++ tests/sh.test       7 Oct 2004 09:53:02 -0000
> @@ -44,10 +44,11 @@
>   status=$EXIT_FAILURE
> fi
>
> -if $EGREP -n -e 'test[         ]+(![   ])?(-.[         ]+)?"?[.,_x]' $scripts; 
> then
> -  echo "use \`test \"X...\"' instead of \`test \"x...\"'"
> -  status=$EXIT_FAILURE
> -fi
> +# disabled for now.
> +#if $EGREP -n -e 'test[        ]+(![   ])?(-.[         ]+)?"?[.,_x]' $scripts; 
> then
> +#  echo "use \`test \"X...\"' instead of \`test \"x...\"'"
> +#  status=$EXIT_FAILURE
> +#fi
>
> # Check for using test X... instead of test "X...
> if $EGREP -n -e 'test[  ]+(![   ])?(-.[         ]+)?X' $scripts; then
> @@ -68,7 +69,7 @@
> fi
>
> # Check for problems with variable assignments.
> -if $EGREP -n -e '[^     ]=[^    ].*(break|continue)' $scripts; then
> +if $EGREP -n -e '[^     ]=[^    ][^&]*(break|continue)' $scripts; then
>   echo "assignments on the same line as a \`break' or \`continue' may have no 
> effect"
>   status=$EXIT_FAILURE
> fi

======================================
Bob Friesenhahn
address@hidden
http://www.simplesystems.org/users/bfriesen