libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Latest Windows tests status


From: Charles Wilson
Subject: Re: Latest Windows tests status
Date: Sun, 10 Oct 2004 21:15:09 -0400
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040616 MultiZilla/1.6.4.0b

Bob Friesenhahn wrote:

On my system I obtain these test results for libtool-branch-2-0:

Cygwin:

====================================
3 of 97 tests failed
(2 tests were not run)
Please report to address@hidden
====================================

My guess:
  quote.test
  link.test
  depdemo-relink.test
Although none of those would lead to skipping anything.  Hmm.  Anyway,

quote.test is fixed using this patch from Noah Misch:
http://lists.gnu.org/archive/html/libtool-patches/2004-10/msg00126.html

link.test was discussed yesterday, but nobody officially submitted a patch for it. The attached works for me.

Finally, depdemo-relink.test is the resurrection of hardcode-relink2, I believe, which is a long-standing bug on cygwin related to fileutils (coreutils, now) and how it munges filenames with/without .exe extensions. I tracked down the problem at one point, but since cygwin has no coreutils maintainer right now, there's nobody to fix it. It's not a libtool bug, AFAICT.

--
Chuck




2004-10-10  Charles Wilson  <spam.protected>

        * tests/link.test: be more robust in the presence
        of chatty libtool messages.
Index: link.test
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/link.test,v
retrieving revision 1.8
diff -u -r1.8 link.test
--- link.test   23 Sep 2004 14:50:36 -0000      1.8
+++ link.test   11 Oct 2004 01:13:16 -0000
@@ -28,10 +28,10 @@
 test $? -eq 0 || exit $EXIT_FAILURE
 
 echo "$linkresult"
-case "$linkresult" in
-*../lib/libnlsut.a) ;;
-*)
+
+testlinkresult=`echo "$linkresult" | ${EGREP} "../lib/libnlsut.a"`
+if test -z "$testlinkresult" ; then
   func_fail "$progname: ../lib/libnlsut.a was not used as expected in linking"
-  ;;
-esac
+fi
+
 exit $EXIT_SUCCESS

reply via email to

[Prev in Thread] Current Thread [Next in Thread]