libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: eval $show when we $run eval


From: Peter O'Gorman
Subject: Re: eval $show when we $run eval
Date: Thu, 14 Oct 2004 00:08:27 +0900
User-agent: Mozilla Thunderbird 0.7.3 (Macintosh/20040803)

Gary V. Vaughan wrote:

Hi Peter,

Peter O'Gorman wrote:

Okay to commit?


Not quite....


Index: ChangeLog
2004-10-13  Peter O'Gorman  <address@hidden>

        * config/ltmain.m4sh: Make sure that we $show what we will $run,
        use eval $show if we do $run eval.


-      $show "$command"
+      eval $show "$command"


eval will strip the quotes, so that $show will run on the bare $command
expansion, which may contain chars special to the shell, e.g ;

I think the changed lines should read (untested!):

    eval \$show \"$command\"

Hmmm.... maybe $command contains " marks too :-(  If that is a possibility
then $command must be passed through func_quote_for_eval():

    func_quote_for_eval "$command"
    eval \$show \"$func_quote_for_eval_result\"

Oh no, I just committed it to both HEAD and branch-2-0. It did pass all it's tests, but I'll get around to making these modifications tomorrow.

Sorry,
Peter
--
Peter O'Gorman - http://www.pogma.com




reply via email to

[Prev in Thread] Current Thread [Next in Thread]