[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: subdir-object compatibility Autotests [libtool--devo--1.0--patch-260
From: |
Noah Misch |
Subject: |
Re: subdir-object compatibility Autotests [libtool--devo--1.0--patch-260] |
Date: |
Wed, 13 Oct 2004 13:08:36 -0700 |
User-agent: |
Mutt/1.5.6i |
Gary,
> +# Hook the test suite into the check rule
> +check-local: tests/atconfig $(TESTSUITE)
> + $(SHELL) $(srcdir)/$(TESTSUITE)
> +
I like ``$(SHELL) $(srcdir)/$(TESTSUITE) $(TESTSUITE_FLAGS)'' to make it easier
for the user to pass options to the test suite. Please consider it.
> +# Run the test suite on the *installed* tree.
> +installcheck-local:
> + $(SHELL) $(srcdir)/$(TESTSUITE) AUTOTEST_PATH=$(exec_prefix)/bin
Likewise.
> +# AT_BOOTSTRAP
> +# ------------
> +m4_define([AT_BOOTSTRAP],
> +[[LIBTOOLIZE=${abs_top_builddir}/libtoolize
> +export LIBTOOLIZE
> +
> +test -f ./ltmain.sh || $LIBTOOLIZE --copy
> +test -f ./configure || autoreconf --force --verbose --install
> +test -f ./configure || exit 1
> +./configure
> +${MAKE-make}
> +]])
This framework uses the user's installations of Autoconf and Automake to
bootstrap the tests, so the test suite will actually test libtool's behavior on
platform-acversion-amversion tuples. Is that intentional? I kind of like that,
since the suite will test the collection of tools the user will actually employ.
If the test suite comes to run all tests in this manner, it will probably take
about twice as long to run. I suppose that is worth the added precision.