Re: [PATCH-2.0] 51-peter-func_extract_an_archive-2.0.patch

[Ralf Wildenhues]

Hi Peter,

Happy New Year to you and to all readers!

* Peter O'Gorman wrote on Tue, Jan 04, 2005 at 12:07:42AM CET:
> 
> This is pretty much the same as HEAD but it lacks the tests. Okay to apply?

Looks good to me, please do.  Thanks for porting!

I noticed we are inconsistent w.r.t. function headers.  I like
| func_foo ()
| {
|   # ...
| }

better than
| func_foo () {
|   # ...
| }

for aesthetic reasons and because my editor will find the function start
in the first case.

If we can agree on this, I can follow up your patch with one that
changes all functions to look like this (plus add a note to HACKING).
No need for you to change your patch.

Regards,
Ralf

> Index: ChangeLog
> 2005-1-1  Peter O'Gorman  <address@hidden>
> 
>       * config/ltmain.m4sh (func_extract_archives,func_extract_an_archive): 
>       On darwin, uniq can not take the flags -cd together, thanks to Ralf
>       for the fix, also ar does not accept N, so we use the fact that
>       ar x libfoo.a foo.o will always extract the first foo.o in the
>       archive and we then delete foo.o from the archive, which will also
>       delete only the first foo.o, then rinse and repeat.
> 
*snip*
> @@ -917,6 +917,46 @@ static const void *lt_preloaded_setup() 
>      fi
>  }
>  
> +# func_extract_an_archive dir oldlib
> +func_extract_an_archive () {
> +    $opt_debug
> +    f_ex_an_ar_dir="$1"; shift
*snip*