[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: shell portability: don't use `set --'
From: |
Ralf Wildenhues |
Subject: |
Re: shell portability: don't use `set --' |
Date: |
Mon, 10 Jan 2005 12:05:21 +0100 |
User-agent: |
Mutt/1.4.1i |
Hi Gary,
* Gary V. Vaughan wrote on Sun, Jan 09, 2005 at 06:01:01PM CET:
> Ralf Wildenhues wrote:
> >
> > How 'bout this? Turned out to be a little work cleaning up the
> > remaining failures of the new test..
> > (Not so sure if I like the results better; bit of a quick hack).
*snip*
> > * tests/sh.test: After `set dummy [...]', check for `shift'
> > within the same and following line.
> > * config/ltmain.m4sh (func_enable_tag, func_mode_install,
> > func_mode_link): Sprinkle `shift's all over to confirm to this.
>
> If there are no regressions, looks like a no-brainer to me.
>
> Please commit!
Done (to HEAD and branch-2-0).
Could you please have a look at these proposed patches as well?
http://lists.gnu.org/archive/html/libtool-patches/2005-01/msg00024.html
(pending use of $as_cr_alnum -- I asked for this on the Autoconf list).
http://lists.gnu.org/archive/html/libtool-patches/2004-12/msg00187.html
You might have reason to rather want this in lt_system.h, and since you
use this header in another project as well, I'd like you to make that
decision.
Thanks,
Ralf