[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FYI: make libtoolize's pkgvdatadir a private api [libtool--devo--1.0
From: |
Ralf Wildenhues |
Subject: |
Re: FYI: make libtoolize's pkgvdatadir a private api [libtool--devo--1.0--patch-105] |
Date: |
Tue, 5 Apr 2005 10:02:01 +0200 |
User-agent: |
Mutt/1.4.1i |
Hi Gary,
* Gary V. Vaughan wrote on Mon, Apr 04, 2005 at 07:15:22PM CEST:
>
> Applied to HEAD.
> * libtoolize.m4sh (pkgvdatadir): Renamed from this...
> (_lt_pkgvdatadir): ...to this.
> * tests/testsuite.at (LT_AT_LIBTOOLIZE): The `-I' option is no
> longer supported by libtoolize. Set _lt_pkgvdatadir in the
> environment of the invocation instead.
All nice and well (thanks BTW), except that..
> --- orig/tests/testsuite.at
> +++ mod/tests/testsuite.at
> @@ -1,7 +1,7 @@
> # Process with autom4te to create an -*- Autotest -*- test suite.
>
> # Test suite for GNU Libtool.
> -# Copyright 2004 Free Software Foundation, Inc.
> +# Copyright 2004, 2005 Free Software Foundation, Inc.
>
> # This program is free software; you can redistribute it and/or modify
> # it under the terms of the GNU General Public License as published by
> @@ -26,7 +26,7 @@
> # LT_AT_LIBTOOLIZE([ARGS])
> # ------------------------
> m4_define([LT_AT_LIBTOOLIZE],
> -["$LIBTOOLIZE" -I "$abs_top_srcdir" -I "$abs_top_srcdir/config" $1
> +[_lt_pkgvdatadir="$abs_top_srcdir" "$LIBTOOLIZE" $1
> ])
>
after this, the am-subdir tests do find the m4 files, but not ltmain.sh
(notice the `autoreconf --force' will also invoke `libtoolize --force'
again).
OK to apply this fix? Or rather drop --force?
Regards,
Ralf
Index: tests/testsuite.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/testsuite.at,v
retrieving revision 1.9
diff -u -r1.9 testsuite.at
--- tests/testsuite.at 4 Apr 2005 17:24:40 -0000 1.9
+++ tests/testsuite.at 5 Apr 2005 08:01:14 -0000
@@ -43,7 +43,7 @@
m4_define([LT_AT_BOOTSTRAP],
[
test -f ./ltmain.sh || LT_AT_LIBTOOLIZE([--copy])
-test -f ./configure || autoreconf --force --verbose --install
+test -f ./configure || _lt_pkgvdatadir="$abs_top_srcdir" autoreconf --force
--verbose --install
test -f ./configure || exit 1
./configure
])