FYI: libtool: cygwin/mingw/pw update: enable-auto-image-base

[Ralf Wildenhues]

Hi Bob, Earnie, Charles, Peter, everyone, :)

* Bob Friesenhahn wrote on Wed, Sep 07, 2005 at 09:23:18PM CEST:
> On Wed, 7 Sep 2005, Earnie Boyd wrote:
> 
> >I'm not opposed either, I believe it is the default, IIRC.  The pw port 
> >isn't
> >maintained that I've noticed.  The submitter is the authority for Cygwin.
> 
> The comment about pw is an understatement. It seems to me that 'pw' 
> failed shortly after leaving the gate due to being a rebel without a 
> cause.  It failed years ago and support for it should be removed from 
> libtool.

*blush* I never knew what pw really was, and thought maybe it was so
clear to everybody that I didn't bother to actually ask..

Anyways, thanks everyone who helped in this thread.  After reading all
provided references, I have applied the patch to both CVS HEAD and
branch-1-5.  For reference, the backport is shown below.

(By the way, should this setting ever be made overridable by the user,
we could think about moving it to be before $compiler_flags, right?)

Cheers,
Ralf

2005-09-08  Charles Wilson  <address@hidden>

        * libtool.m4 (AC_LIBTOOL_LANG_CXX_CONFIG)
        (AC_LIBTOOL_PROG_LD_SHLIBS) [ cygwin, mingw, pw32 ]: Use
        --enable-auto-image-base instead of a fixed image base address.

Index: libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/Attic/libtool.m4,v
retrieving revision 1.314.2.108
diff -u -r1.314.2.108 libtool.m4
--- libtool.m4  6 Sep 2005 08:59:00 -0000       1.314.2.108
+++ libtool.m4  8 Sep 2005 06:58:25 -0000
@@ -2944,7 +2944,7 @@
     _LT_AC_TAGVAR(enable_shared_with_static_runtimes, $1)=yes
 
     if $LD --help 2>&1 | grep 'auto-import' > /dev/null; then
-      _LT_AC_TAGVAR(archive_cmds, $1)='$CC -shared -nostdlib $predep_objects 
$libobjs $deplibs $postdep_objects $compiler_flags -o $output_objdir/$soname 
${wl}--image-base=0x10000000 ${wl}--out-implib,$lib'
+      _LT_AC_TAGVAR(archive_cmds, $1)='$CC -shared -nostdlib $predep_objects 
$libobjs $deplibs $postdep_objects $compiler_flags -o $output_objdir/$soname 
${wl}--enable-auto-image-base ${wl}--out-implib,$lib'
       # If the export-symbols file already is a .def file (1st line
       # is EXPORTS), use it as is; otherwise, prepend...
       _LT_AC_TAGVAR(archive_expsym_cmds, $1)='if test "x`$SED 1q 
$export_symbols`" = xEXPORTS; then
@@ -2953,7 +2953,7 @@
        echo EXPORTS > $output_objdir/$soname.def;
        cat $export_symbols >> $output_objdir/$soname.def;
       fi~
-      $CC -shared -nostdlib $output_objdir/$soname.def $predep_objects 
$libobjs $deplibs $postdep_objects $compiler_flags -o $output_objdir/$soname 
${wl}--image-base=0x10000000 ${wl}--out-implib,$lib'
+      $CC -shared -nostdlib $output_objdir/$soname.def $predep_objects 
$libobjs $deplibs $postdep_objects $compiler_flags -o $output_objdir/$soname 
${wl}--enable-auto-image-base ${wl}--out-implib,$lib'
     else
       _LT_AC_TAGVAR(ld_shlibs, $1)=no
     fi
@@ -5344,7 +5344,7 @@
       _LT_AC_TAGVAR(export_symbols_cmds, $1)='$NM $libobjs $convenience | 
$global_symbol_pipe | $SED -e '\''/^[[BCDGRS]] /s/.* \([[^ ]]*\)/\1 DATA/'\'' | 
$SED -e '\''/^[[AITW]] /s/.* //'\'' | sort | uniq > $export_symbols'
 
       if $LD --help 2>&1 | grep 'auto-import' > /dev/null; then
-        _LT_AC_TAGVAR(archive_cmds, $1)='$CC -shared $libobjs $deplibs 
$compiler_flags -o $output_objdir/$soname ${wl}--image-base=0x10000000 
${wl}--out-implib,$lib'
+        _LT_AC_TAGVAR(archive_cmds, $1)='$CC -shared $libobjs $deplibs 
$compiler_flags -o $output_objdir/$soname ${wl}--enable-auto-image-base 
${wl}--out-implib,$lib'
        # If the export-symbols file already is a .def file (1st line
        # is EXPORTS), use it as is; otherwise, prepend...
        _LT_AC_TAGVAR(archive_expsym_cmds, $1)='if test "x`$SED 1q 
$export_symbols`" = xEXPORTS; then
@@ -5353,7 +5353,7 @@
          echo EXPORTS > $output_objdir/$soname.def;
          cat $export_symbols >> $output_objdir/$soname.def;
        fi~
-       $CC -shared $output_objdir/$soname.def $libobjs $deplibs 
$compiler_flags -o $output_objdir/$soname ${wl}--image-base=0x10000000  
${wl}--out-implib,$lib'
+       $CC -shared $output_objdir/$soname.def $libobjs $deplibs 
$compiler_flags -o $output_objdir/$soname ${wl}--enable-auto-image-base  
${wl}--out-implib,$lib'
       else
        _LT_AC_TAGVAR(ld_shlibs, $1)=no
       fi