FYI: Make sure compiler is assigned

[Peter Ekberg]

* Ralf Wildenhues wrote on Wednesday, September 21, 2005 21:03 CEST:
> Hi Peter,
> 
> * Peter Ekberg wrote on Wed, Sep 21, 2005 at 07:30:20PM CEST:
> > 
> > Here's another old thing sitting locally.
> 
> Yes, and that one I remember why I held it back: _LT_TAG_COMPILER is
> both used through a m4_require and through direct calls.  This is not
> very safe, and I don't like it much.  I looked at the 
> differences in the
> generated output now, and believe it's ok for this one.
> 
> > And here's the trivial patch in case that's what's holding
> > this up:
> > 
> >     * libltdl/m4/libtool.m4 (_LT_CMD_GLOBAL_SYMBOLS): Require
> >     _LT_TAG_COMPILER to make sure that $compiler is assigned.
> >     Fixes crippled configure output.
> 
> _LT_COMPILER_PIC and _LT_LINKER_SHLIBS also lack the m4_require.
> Please add them, too (at the end of the requires!) and commit to HEAD.

Great, thanks. Applied this patch:

Index: libltdl/m4/libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/m4/libtool.m4,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- libltdl/m4/libtool.m4       21 Sep 2005 16:50:18 -0000      1.20
+++ libltdl/m4/libtool.m4       22 Sep 2005 04:53:14 -0000      1.21
@@ -3003,6 +3003,7 @@
 AC_REQUIRE([LT_PATH_NM])dnl
 AC_REQUIRE([LT_PATH_LD])dnl
 m4_require([_LT_DECL_EGREP])dnl
+m4_require([_LT_TAG_COMPILER])dnl
 
 # Check for command to grab the raw symbol name followed by C symbol
from nm.
 AC_MSG_CHECKING([command to parse $NM output from $compiler object])
@@ -3215,7 +3216,8 @@
 # _LT_COMPILER_PIC([TAGNAME])
 # ---------------------------
 m4_defun([_LT_COMPILER_PIC],
-[_LT_TAGVAR(lt_prog_compiler_wl, $1)=
+[m4_require([_LT_TAG_COMPILER])dnl
+_LT_TAGVAR(lt_prog_compiler_wl, $1)=
 _LT_TAGVAR(lt_prog_compiler_pic, $1)=
 _LT_TAGVAR(lt_prog_compiler_static, $1)=
 
@@ -3766,6 +3768,7 @@
 m4_require([_LT_FILEUTILS_DEFAULTS])dnl
 m4_require([_LT_DECL_EGREP])dnl
 m4_require([_LT_CMD_GLOBAL_SYMBOLS])dnl
+m4_require([_LT_TAG_COMPILER])dnl
 AC_MSG_CHECKING([whether the $compiler linker ($LD) supports shared
libraries])
 m4_if([$1], [CXX], [
   _LT_TAGVAR(export_symbols_cmds, $1)='$NM $libobjs $convenience |
$global_symbol_pipe | $SED '\''s/.* //'\'' | sort | uniq >
$export_symbols'