Re: include_expsyms clobbers user files.

[Ralf Wildenhues]

Hi Peter,

* Peter Ekberg wrote on Thu, Sep 22, 2005 at 10:00:32AM CEST:
> * Ralf Wildenhues wrote on Wednesday, September 21, 2005 22:37 CEST:
> > * Peter Ekberg wrote on Mon, Sep 19, 2005 at 09:05:04PM CEST:

> > > Thinking about it further, include_expsyms is perhaps not
> > > buggy with skipped exports, as then the needed symbols perhaps
> > > get exported anyway with the export_symbols_cmds functionality.
> > > A check wouldn't hurt though...

> But looking closer, include_expsyms is a disaster area. Since it
> isn't used, my vote is to zap it completely.
> 
> The problem is that it potentially clobbers user provided files,
> so that building repeatedly will eat up all your disk space
> eventually (but that isn't the worst problem with clobbering
> user provided files of course).

Why not make a copy of the user-provided file and append to that?
C'mon, that isn't rocket science.  Unless there are other reasons
against include_expsyms, that is.

> So, zap it? Or is include_expsyms somehow a hook for "outside
> users"?

To be honest, I don't know.  But it's nicely symmetrical with
exclude_expsyms, and the latter is useful.  I can imagine situations
where the former can be useful.

Cheers,
Ralf