[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
compiler warning fixes for cygwin
From: |
Eric Blake |
Subject: |
compiler warning fixes for cygwin |
Date: |
Thu, 22 Sep 2005 20:00:06 -0600 |
User-agent: |
Mozilla Thunderbird 1.0.2 (Windows/20050317) |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Compiling with -Wall -Werror often turns up some interesting bugs. The
whitespace in this file is also a bit screwy, according to emacs
whitespace mode.
libltdl/loaders/loadlibrary.c: In function `vm_open':
libltdl/loaders/loadlibrary.c:138: warning: implicit declaration of
function `cygwin_conv_to_full_win32_path'
libltdl/loaders/loadlibrary.c:161: warning: suggest parentheses around
assignment used as truth value
libltdl/loaders/loadlibrary.c:95: warning: unused variable `errormsg'
make[2]: *** [libltdl/loaders/loadlibrary.lo] Error 1
2005-09-22 Eric Blake <address@hidden> (tiny change)
* libltdl/loaders/loadlibrary.c (vm_open): Silence gcc warnings.
[__CYGWIN__]: Include <sys/cygwin.h> for prototype.
- --
Life is short - so eat dessert first!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFDM2Gm84KuGfSFAYARAhyqAJ9r+zho9EJD5MT7GbPN0YJ4pmdAdwCgnSjw
VbXtqZtycztefMQ4KDNc2so=
=GE6a
-----END PGP SIGNATURE-----
Index: libltdl/loaders/loadlibrary.c
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/loaders/loadlibrary.c,v
retrieving revision 1.8
diff -u -p -b -r1.8 loadlibrary.c
--- libltdl/loaders/loadlibrary.c 28 Jul 2005 10:15:57 -0000 1.8
+++ libltdl/loaders/loadlibrary.c 23 Sep 2005 01:57:52 -0000
@@ -1,5 +1,5 @@
/* loader-loadlibrary.c -- dynamic linking for Win32
- Copyright (C) 1998, 1999, 2000, 2004 Free Software Foundation, Inc.
+ Copyright (C) 1998, 1999, 2000, 2004, 2005 Free Software Foundation, Inc.
Originally by Thomas Tanner <address@hidden>
NOTE: The canonical source of this file is maintained with the
@@ -30,6 +30,10 @@ Foundation, Inc., 51 Franklin Street, Fi
#include "lt__private.h"
#include "lt_dlloader.h"
+#if defined(__CYGWIN__)
+# include <sys/cygwin.h>
+#endif
+
/* Use the preprocessor to rename non-static symbols to avoid namespace
collisions when the loader code is statically linked into libltdl.
Use the "<module_name>_LTX_" prefix so that the symbol addresses can
@@ -92,7 +96,6 @@ static lt_module
vm_open (lt_user_data loader_data, const char *filename)
{
lt_module module = 0;
- const char *errormsg = 0;
char *searchname = 0;
char *ext;
char self_name_buf[MAX_PATH];
@@ -158,7 +161,7 @@ vm_open (lt_user_data loader_data, const
{
lt__handle * cur = 0;
- while (cur = (lt__handle *) lt_dlhandle_next ((lt_dlhandle) cur))
+ while ((cur = (lt__handle *) lt_dlhandle_next ((lt_dlhandle) cur)))
{
if (!cur->module)
{
- compiler warning fixes for cygwin,
Eric Blake <=