Re: 277-gary-rename-remaining-troublesome-ltdl-apis.diff

[Ralf Wildenhues]

Hi Gary,

* Gary V. Vaughan wrote on Sun, Sep 18, 2005 at 02:30:03AM CEST:
> Okay to commit?
> 
> This fixes the remaining holes that allowed libltdl clients to stumble
> across each others' loaded modules.  Of course, there is nothing to
> prevent clients from registering a dumb interface validator that returns
> other clients' modules... hopefully the extra stuff I've added to the
> manual makes it clear how to do it properly though.

Huh?  Once again I fail to grasp why you want to remove functionality.
AFAICS lt_dlforeach, lt_dlhandle_next are the ones present in 1.5.x, the
other to-be-killed ones were added later.  Is this correct?

The new stuff looks, umm, well, new to me.  As in: would need a bit of
real-world experience to prove that "this new interface can finally live
up to user's needs", which apparently all the previous versions could
not.  So, no, I'm not convinced by either removing the old interfaces
nor adding the new ones, although the new ones do not look suspicious
per se.  Also, we have no code that tests the new interfaces at all.
Not even CVS m4.

lt_dlhandle_next already has the machinery to do the right thing.  Right?

I should reiterate Bob's statement: only _minimal_ changes should be
necessary to stabilize.  Sarcastically, I should add: For every
interface that is removed, both the person originally creating the
interface, and, to lesser extent, the one removing it should be
punished.  :->

> Once this is committed, we can remove another of the remaining release
> blockers... :-D

AFAICS that was already done with 275 and 276.  No need for this one.
Am I missing something again?

Cheers,
Ralf

* Gary V. Vaughan wrote on Mon, Sep 19, 2005 at 01:45:15AM CEST:
> Repost.  This one applies cleanly over 275 and 276, posted earlier.
> 
>  ChangeLog        |   11 +++
>  NEWS             |    9 +-
>  doc/libtool.texi |  176 
> +++++++++++++++++++++----------------------------------
>  libltdl/ltdl.c   |   84 +++++++++-----------------
>  libltdl/ltdl.h   |   10 +--
>  5 files changed, 123 insertions(+), 167 deletions(-)

> Index: libtool--devo--1.0/ChangeLog
> ===================================================================
> --- libtool--devo--1.0.orig/ChangeLog
> +++ libtool--devo--1.0/ChangeLog
> @@ -1,3 +1,14 @@
> +2005-09-18  Gary V. Vaughan  <address@hidden>
> +
> +     * libltdl/ltdl.h, libltdl/ltdl.c (lt_dlhandle_first): Removed.
> +     * libltdl/ltdl.h, libltdl/ltdl.c (lt_dlhandle_next)
> +     (lt_dlhandle_find, lt_dlforeach): Removed...
> +     (lt_dlhandle_iterate, lt_dlhandle_fetch, lt_dlhandle_map): Similar
> +     functions that are multi-loader safe, and require a registered
> +     interface validator argument.
> +     * doc/libtool.texi: Updated.
> +     * NEWS: Updated.
> +
>  2005-09-17  Gary V. Vaughan  <address@hidden>
>  
>       * libltdl/ltdl.h (lt_dlmutex_register, lt_dlmutex_lock)
> Index: libtool--devo--1.0/NEWS
> ===================================================================
> --- libtool--devo--1.0.orig/NEWS
> +++ libtool--devo--1.0/NEWS
> @@ -3,11 +3,12 @@ NEWS - list of user-visible changes betw
>  New in 1.9h: 2005-??-??; CVS version 2.1a, Libtool team:
>  * New tests for support of Automake subdir-objects.
>  * Fix libltdl on static platforms.
> -* New lt_dlinterface_register, lt_dlinterface_set_data and
> -  lt_dlinterface_get_data libltdl API calls to maintain separation of
> -  concerns between modules loaded by different libraries.
> +* New multi-module-loader safe libltdl handle iteration APIs:
> +  lt_dlhandle_iterate, lt_dlhandle_fetch, lt_dlhandle_map.
> +* New lt_dlinterface_register to maintain separation of concerns between
> +  modules loaded by different libraries.
>  * Removed deprecated APIs from libltdl: lt_dlcaller_register,
> -  lt_dlcaller_get_data, lt_dlcaller_set_data, lt_dlmutex_register,
> +  lt_dlhandle_next, lt_dlhandle_find, lt_dlforeach, lt_dlmutex_register,
>    lt_dlmutex_lock, lt_dlmutex_unlock, lt_dlmutex_seterror,
>    lt_dlmutex_geterror, lt_dlmalloc, lt_dlrealloc, lt_dlfree.
>  * Support for Portland Group compiler on GNU/Linux.
*snip*