Re: branch-1-5 UnixWare fixes

[Ralf Wildenhues]

Hi Tim,

* Tim Rice wrote on Sun, Sep 25, 2005 at 10:05:21PM CEST:
> On Sun, 25 Sep 2005, Ralf Wildenhues wrote:
> : * Tim Rice wrote on Fri, Sep 23, 2005 at 10:20:29PM CEST:
> : > 
> : > I did some work on branch-1-5 to try and get libtool fully functional
> : > on UnixWare 7.1.4. I was mostly successful, only the quote test fails.
> : > Probably a ksh bug.
> : 
> : Which of the quote test lines fail?  Did you run the test in a new build
> : tree or did you ever re-configure (there is a bug in branch-1-5 wrt.
> 
> Always a fresh build tree.

OK.

> : setting $SHELL correctly on a config.status-induced configure rerun.  If
> : in doubt retry with a new build tree)
> 
> I re-ran the tests using ksh88 and all tests passed.
> Must be a ksh bug.
> Version M-11/16/88h           passes quote test
> Version M-12/28/93e-SCO               fails quote test

Please post the failing output of
  make check TESTS=quote.test VERBOSE=x

Thank you.

*snip*
> : Content-Description: branch-1-5-uw.patch
> [snip]
> : > @@ -2314,11 +2327,11 @@
> : >    lt_cv_deplibs_check_method=pass_all
> : >    ;;
> : >  
> : > -sysv5OpenUNIX8* | sysv5UnixWare7* | sysv5uw[[78]]*)
> : > +sysv5*)
> : >    lt_cv_deplibs_check_method=pass_all
> : >    ;;
> : >  
> : > -sysv4 | sysv4.2uw2* | sysv4.3* | sysv5*)
> : > +sysv4 | sysv4.2uw2* | sysv4.3*)
> : >    case $host_vendor in
> : >    motorola)
> : >      lt_cv_deplibs_check_method='file_magic ELF [[0-9]][[0-9]]*-bit 
> [[ML]]SB (shared object|dynamic lib) M[[0-9]][[0-9]]* Version [[0-9]]'
> : > @@ -2339,10 +2352,13 @@
> : >    siemens)
> : >      lt_cv_deplibs_check_method=pass_all
> : >      ;;
> : > +  pc)
> : > +    lt_cv_deplibs_check_method=pass_all
> : > +    ;;
> : >    esac
> : >    ;;
> : >  
> : > -sysv4*uw2* | unixware7*)
> : > +unixware7*)
> : 
> : Now, this macro doesn't have a match for sysv4*uw2* any more.  Is this
> : intentional?
> 
> Quite intentional. Look at the case above, it already had sysv4*uw2* so
> the one I removed would never have been used anyway. Adding the "pc)"
> case to the $host_vendor part did what the other case was supposed to do.

Erm, it had sysv4.2uw2* but not sysv4*uw2*.  If both should be treated
similarly here, then you should replace the former with the latter (in
the line where sysv4 is also matched)

> It could be cleanded up further by having "sysv5* | unixware7*)".
> (UnixWare 7 is sysv5)

Hmm, then both of those should be treated similarly, I guess?

> I assume that unixware7* is in there for backward compatibility for
> some old config.guess.

I have no idea, really.

> : 
> : >    lt_cv_deplibs_check_method=pass_all
> : >    ;;
> : >  esac
> [snip]
> : > @@ -5404,7 +5448,7 @@
> : >        fi
> : >        ;;
> : >  
> : > -    solaris* | sysv5*)
> : > +    solaris*)
> : 
> : Any reason for this change?
> 
> Oops, that's one of the things I tried that didn't make any difference.
> Best to leave that in for now.

OK.

*snip large hunk*
> : 
> : You removed setting of archive_expsym_cmds here.  Was this intentional?
> : Did it not work?
> 
> Yes intentional, tests fail with it in.

OK, fine then.

Cheers, and thanks again,
Ralf