[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 285-gary-diagnose-missing-LT_WITH_LTDL.diff
From: |
Gary V. Vaughan |
Subject: |
Re: 285-gary-diagnose-missing-LT_WITH_LTDL.diff |
Date: |
Fri, 30 Sep 2005 14:53:58 +0100 |
User-agent: |
Mozilla Thunderbird 1.0 (X11/20050305) |
Ralf Wildenhues wrote:
Hi Gary,
Hi Ralf,
Thanks for the review.
* Gary V. Vaughan wrote on Fri, Sep 30, 2005 at 01:47:26PM CEST:
And if I'd remembered to make before make check, I would have noticed
a stupid shell script bug. Fixed in this version, please disregard the
parent post.
Okay to commit?
No. With the last checkin, you broke test 4 (and I didn't notice :-/ ),
this one breaks 1-4 at least. Please fixup the last checkin first, then
redo this one, then repost this one. And _then_, I'll retest.
Odd...
$ pwd
/Users/gary/devel/savannah/libtool--devo--1.0/+build
$ quilt applied
../patches/277-gary-rename-remaining-troublesome-ltdl-apis.diff
../patches/279-gary-LT_CONFIG_LTDL_DIR.diff
../patches/283-gary-test-subproject-ltdl.diff
../patches/284-gary-report-macro-files-for-aclocal.diff
../patches/285-gary-diagnose-missing-LT_WITH_LTDL.diff
$ make
...
$ make check
...
====================
All 124 tests passed
====================
...
1: libtoolize macro installation ok
2: libtoolize macro serial update ok
3: libtoolize config files serial update ok
4: copy ltdl.m4 with shared macro directory ok
...
Subproject Libltdl.
21: compiling softlinked libltdl ok
22: compiling copied libltdl ok
23: installable libltdl ok
24: linking libltdl without autotools ok
...
## ------------- ##
## Test results. ##
## ------------- ##
All 29 tests were successful.
If there are any dependencies to other patches of yours not yet applied,
please post so. I haven't forgotten your old ones, but the hairy ones
just take a lot more time, and I'd like to keep the number of items on
stack low if possible.
Okay, I'll stop flooding the list with new patches, and go back
to concentrating on finishing splitting up the LT_WITH_LTDL fix. Once
our trees are back in sync, and there are no patches between what I'm
posting and what you're testing, things should be much easier. More
hair to follow... ;-)
If you're seeing failures, then there must be a dependency on
277 or 279.
Cheers,
Gary.
--
Gary V. Vaughan ())_. address@hidden,gnu.org}
Research Scientist ( '/ http://tkd.kicks-ass.net
GNU Hacker / )= http://www.gnu.org/software/libtool
Technical Author `(_~)_ http://sources.redhat.com/autobook
signature.asc
Description: OpenPGP digital signature