|
From: | Peter O'Gorman |
Subject: | Re: don't add -isysroot to compiler flags if already in $CC |
Date: | Fri, 02 Dec 2005 10:17:59 +0900 |
User-agent: | Mozilla Thunderbird 1.0.2 (Macintosh/20050317) |
Hi Ralf, Ralf Wildenhues wrote:
OK. But I don't see where we make sure $compile_command never gets duplicates.. anyway, I guess this part is fine, you'd have seen it.
archive_cmds looks like "$CC ... $compiler_flags..." So if a flag is in CC and we grok it, we also add it to $compiler_flags when we see it on the command line. Any flag that we grok and put in compiler_flags will appear twice on the link line if it is in CC.
Is this version okay & forward port? A space and a tab check is quite satisfactory for me, I don't see the need to go overboard here.Any reason against using [ ] for this? I mean, other than the fact that the forward-port will need another set of []?
When I tried it it did not work. $cat test.sh #! /bin/sh a=hello b=world c="hello world" case " $c " in *" ${a}[ ]${b} "*) echo yippee; break;; esac $ ./test.sh $
Oops looks like I need to fix indentation too. Please pretend that that is okay for now :)Sure. No, the patch is not ok. You remove prev=darwin_framework, i.e., effectively the following argument will not be looped over, thus it won't be quoted and end up in $libtool_args, thus $relink_command will be wrong, thus relinking will fail, if only because there'll be a `-framework' without argument in it. Right?
It passed all its tests, presumably because darwin does not relink. I'll look into a proper fix though.
Peter
[Prev in Thread] | Current Thread | [Next in Thread] |