libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libtool.m4 on DragonFly


From: Ralf Wildenhues
Subject: Re: libtool.m4 on DragonFly
Date: Thu, 9 Mar 2006 13:27:27 +0100
User-agent: Mutt/1.5.11

Hi Jeremy,

* Jeremy C. Reed wrote on Thu, Mar 09, 2006 at 03:15:06AM CET:
> 
> Can you please update libtool.m4 for DragonFly support?

Yes.  I plan to return to Libtool work next week, hopefully,
and will address all regressions I have put in 1.5.22 then.

A couple of comments tough:

> --- /home/reed/pkg/share/aclocal/libtool.m4.orig      2006-03-02 
> 10:18:11.000000000 -0800
> +++ /home/reed/pkg/share/aclocal/libtool.m4   2006-03-02 10:21:37.000000000 
> -0800
> @@ -1415,13 +1415,13 @@
>      esac
>    fi
>    version_type=freebsd-$objformat
> -  case $version_type in
> -    freebsd-elf*)
> +  case $objformat in
> +    elf)
>        library_names_spec='${libname}${release}${shared_ext}$versuffix 
> ${libname}${release}${shared_ext} $libname${shared_ext}'
>        need_version=no
>        need_lib_prefix=no
>        ;;
> -    freebsd-*)
> +    *)
>        library_names_spec='${libname}${release}${shared_ext}$versuffix 
> $libname${shared_ext}$versuffix'
>        need_version=yes
>        ;;

This change will change the versioning system and thus cause a flag day
for users, just as Todd explained on pkgsrc-users.  I am a bit reluctant
to make the change at all, and very reluctant to make it in branch-1-5.
Certainly open to suggestions though, especially from pkg/ports
maintainers.  Long-term goal would be to have GNU Libtool in synch with
how systems pkgsrc/ports/.. package them, but breaking compatibility in
stable releases is certainly not desirable.

> @@ -1440,7 +1440,7 @@
>      shlibpath_overrides_runpath=no
>      hardcode_into_libs=yes
>      ;;
> -  freebsd*) # from 4.6 on
> +  *) # from 4.6 on, and DragonFly
>      shlibpath_overrides_runpath=yes
>      hardcode_into_libs=yes
>      ;;

This is the regression, and of course needs fixed.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]