[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [png-mng-implement] -version-number and BeOS
From: |
Ralf Wildenhues |
Subject: |
Re: [png-mng-implement] -version-number and BeOS |
Date: |
Sun, 14 May 2006 09:21:30 +0200 |
User-agent: |
Mutt/1.5.11+cvs20060403 |
Hello John, Christian, everyone,
Sorry for the huge delay.
* John Bowler wrote on Fri, Mar 31, 2006 at 09:15:42PM CEST:
> From: Christian Biesinger
> >libtool: link: CURRENT `' must be a nonnegative integer
> >libtool: link: `0:9:0' is not valid version information
> >make[1]: *** [libpng12.la] Error 1
> >The cause of this problem seems to be this:
> >For BeOS, version_type=none. But, the code in ltmain.sh around line 3236
> >does not handle a value of none. Only for the specific list of cases
> >does it assign a value to current, age and revision.
>
> Yes, we found a similar problem with irix and I patched ltmain.sh
> to fix this (ltmain.sh is shipped with the package, so patching it
> works):
OK, I looked at this again. My previous analysis was plain wrong.
I've installed the attached patches to branch-1-5 and HEAD,
respectively.
What I still don't understand is the following additional change you
also suggest:
> $ diff libpng-1.2.9beta7/ltmain.sh libpng-1.2.9beta11
> 3248c3248
> < current=`expr $number_major + $number_minor - 1`
> ---
> > current=`expr $number_major + $number_minor`
> 3323c3323
> < major=`expr $current - $age + 1`
> ---
> > major=`expr $current - $age`
There is a comment above this code that explains why this should be
necessary, no?
> For BeOS try adding 'none' to the end of the test for darwin|linux|osf|windows
> on line 3237 of ltmain.sh. We can ship libpng with that because it won't
> break anything which isn't already broken. I.e:
Done.
Cheers, and thank you for your persistence!
Ralf
HEAD:
2005-05-14 John Bowler <address@hidden>
* libltdl/config/ltmain.m4sh (func_mode_link): For version_type
`none', we still need to set `current', `age', and `revision',
so that our checks don't barf. The values won't be used later.
Apparently reported by several people, several times, for BeOS.
* NEWS, THANKS: Update.
branch-1-5:
2005-05-14 John Bowler <address@hidden>
* ltmain.in (link mode): For version_type `none', we still need
to set `current', `age', and `revision', so that our checks
don't barf. The values won't be used later. Apparently
reported by several people, several times, for BeOS.
* NEWS, THANKS: Update.
HEAD-version-type-none.diff
Description: Text document
1-5-version-type-none.diff
Description: Text document
- Re: [png-mng-implement] -version-number and BeOS,
Ralf Wildenhues <=