HEAD: install broken with install-sh

[Ralf Wildenhues]

Hello everyone,

Dan Lacher reported this bug off-list against CVS Libtool:

* Dan Lacher wrote on Fri, Jun 09, 2006 at 12:40:25PM CEST:
> The top level Makefile I am seeing the following on the make install  
> target:

> /workspace/dlacher/gnu-tools/src/libtool-2.1a/libltdl/config/install- 
> sh -d /workspace/dlacher/gnu-tools/share/aclocal
>  libltdl/config/install-sh -c -m 644 'argz.m4' '/workspace/dlacher/ 
> gnu-tools/share/aclocal/argz.m4'
> /bin/bash: libltdl/config/install-sh: No such file or directory

We may not use $(INSTALL) from another directory.  I'm checking in the
patch below.

Cheers,
Ralf

        * Makefile.am (install-data-local): Do not use $(INSTALL_DATA)
        from another directory: it may use a relative path to
        `install-sh'.
        Bug report by Dan Lacher <address@hidden>.

Index: Makefile.am
===================================================================
RCS file: /cvsroot/libtool/libtool/Makefile.am,v
retrieving revision 1.194
diff -u -r1.194 Makefile.am
--- Makefile.am 15 May 2006 16:14:24 -0000      1.194
+++ Makefile.am 9 Jun 2006 15:02:22 -0000
@@ -325,28 +325,25 @@
 ## with libtoolize, we have to install them in the correct order:
 ## First, put a copy of the libtool m4 macros in the aclocal dir
        $(mkinstalldirs) $(DESTDIR)$(aclocaldir)
-       @cd $(srcdir)/$(m4dir) && \
-       list='$(aclocalfiles)'; for p in $$list; do \
+       @list='$(aclocalfiles)'; for p in $$list; do \
          f=`echo "$$p" | sed 's|^.*/||'`; \
-         echo " $(INSTALL_DATA) '$$f' '$(DESTDIR)$(aclocaldir)/$$f'"; \
-         $(INSTALL_DATA) "$$f" "$(DESTDIR)$(aclocaldir)/$$f"; \
+         echo " $(INSTALL_DATA) '$(srcdir)/$(m4dir)/$$f' 
'$(DESTDIR)$(aclocaldir)/$$f'"; \
+         $(INSTALL_DATA) "$(srcdir)/$(m4dir)/$$f" 
"$(DESTDIR)$(aclocaldir)/$$f"; \
        done
 ## install the helper scripts
        $(mkinstalldirs) $(DESTDIR)$(pkgdatadir)
        $(mkinstalldirs) $(DESTDIR)$(pkgdatadir)/config
-       @cd $(srcdir)/libltdl && \
-       list='$(auxfiles)' && for p in $$list; do \
-         echo " $(INSTALL_SCRIPT) '$$p' '$(DESTDIR)$(pkgdatadir)/$$p'"; \
-         $(INSTALL_SCRIPT) "$$p" "$(DESTDIR)$(pkgdatadir)/$$p"; \
+       @list='$(auxfiles)' && for p in $$list; do \
+         echo " $(INSTALL_SCRIPT) '$(srcdir)/libltdl/$$p' 
'$(DESTDIR)$(pkgdatadir)/$$p'"; \
+         $(INSTALL_SCRIPT) "$(srcdir)/libltdl/$$p" 
"$(DESTDIR)$(pkgdatadir)/$$p"; \
        done
 ## install the libltdl files
        $(mkinstalldirs) $(DESTDIR)$(pkgdatadir)/libltdl
        $(mkinstalldirs) $(DESTDIR)$(pkgdatadir)/libltdl/libltdl
        $(mkinstalldirs) $(DESTDIR)$(pkgdatadir)/libltdl/loaders
-       @cd $(srcdir) && \
-       list='$(ltdldatafiles)' && for p in $$list; do \
-         echo " $(INSTALL_DATA) '$$p' '$(DESTDIR)$(pkgdatadir)/$$p'"; \
-         $(INSTALL_DATA) "$$p" "$(DESTDIR)$(pkgdatadir)/$$p"; \
+       @list='$(ltdldatafiles)' && for p in $$list; do \
+         echo " $(INSTALL_DATA) '$(srcdir)/$$p' 
'$(DESTDIR)$(pkgdatadir)/$$p'"; \
+         $(INSTALL_DATA) "$(srcdir)/$$p" "$(DESTDIR)$(pkgdatadir)/$$p"; \
        done
        -chmod a+x $(DESTDIR)$(pkgdatadir)/libltdl/configure