Re: CVS Head FreeBSD 5.4 test results

[Ralf Wildenhues]

Hi Bob,

* Bob Friesenhahn wrote on Sat, Jan 12, 2008 at 06:34:28AM CET:
> 
>    Subject: [libtool 2.1a] testsuite: 29 32 33 34 55 56 57 59 failed
> 
> A gzipped testsuite.log is attached.
> 
> The test results on Solaris 10 (SPARC and x86) and Apple OS-X Leopard 
> seem reasonable.

Thanks for testing.  AFAICS the test failures all fail for the same
reason: you have set CPPFLAGS=-I/usr/local/include and we put the
include path for just-built libltdl after the CPPFLAGS.

I've applied this patch which should fix all instances.

Cheers,
Ralf

2008-01-12  Ralf Wildenhues  <address@hidden>

        * tests/configure-iface.at: Ensure LTDLINCL is expanded
        before CPPFLAGS, so that even CPPFLAGS=-I/usr/local/include
        won't make the tests prefer an installed ltdl.h over the
        in-package one.
        * tests/lt_dladvise.at, tests/lt_dlexit.at: Likewise.
        * tests/need_lib_prefix.at, tests/old-m4-iface.at: Likewise.
        Report by Bob Friesenhahn.

Index: tests/configure-iface.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/configure-iface.at,v
retrieving revision 1.3
diff -u -r1.3 configure-iface.at
--- tests/configure-iface.at    8 Jan 2008 06:48:49 -0000       1.3
+++ tests/configure-iface.at    12 Jan 2008 11:20:38 -0000
@@ -1,6 +1,6 @@
 # configure-iface.at -- test ltdl configure interface         -*- Autotest -*-
 #
-#   Copyright (C) 2007 Free Software Foundation, Inc.
+#   Copyright (C) 2007, 2008 Free Software Foundation, Inc.
 #   Written by Gary V. Vaughan, 2007
 #
 #   This file is part of GNU Libtool.
@@ -124,7 +124,7 @@
 
 SUBDIRS                        = libltdl
 
-AM_CFLAGS              = $(LTDLINCL)
+AM_CPPFLAGS            = $(LTDLINCL)
 
 lib_LTLIBRARIES                = libmodule.la
 libmodule_la_LDFLAGS   = -module
@@ -188,7 +188,7 @@
 AT_DATA([Makefile.am],
 [[AUTOMAKE_OPTIONS     = 1.7
 
-AM_CFLAGS              = $(LTDLINCL)
+AM_CPPFLAGS            = $(LTDLINCL)
 
 lib_LTLIBRARIES                = libmodule.la
 libmodule_la_LDFLAGS   = -module
@@ -241,7 +241,7 @@
 
 SUBDIRS                        = libltdl
 
-AM_CFLAGS              = $(LTDLINCL)
+AM_CPPFLAGS            = $(LTDLINCL)
 
 lib_LTLIBRARIES                = libmodule.la
 libmodule_la_LDFLAGS   = -module
Index: tests/lt_dladvise.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/lt_dladvise.at,v
retrieving revision 1.2
diff -u -r1.2 lt_dladvise.at
--- tests/lt_dladvise.at        22 May 2007 12:07:06 -0000      1.2
+++ tests/lt_dladvise.at        12 Jan 2008 11:20:39 -0000
@@ -1,6 +1,6 @@
 # lt_dladvise.at -- test libltdl functionality                -*- Autotest -*-
 #
-#   Copyright (C) 2007 Free Software Foundation, Inc.
+#   Copyright (C) 2007, 2008 Free Software Foundation, Inc.
 #   Written by Gary V. Vaughan, 2007
 #
 #   This file is part of GNU Libtool.
@@ -267,7 +267,7 @@
 : ${LTDLINCL="-I$abs_top_srcdir/libltdl"}
 : ${LIBLTDL="$abs_builddir/../libltdl/libltdlc.la"}
 
-CPPFLAGS="$CPPFLAGS $LTDLINCL"
+CPPFLAGS="$LTDLINCL $CPPFLAGS"
 
 dlopenable='resident local global'
 
Index: tests/lt_dlexit.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/lt_dlexit.at,v
retrieving revision 1.7
diff -u -r1.7 lt_dlexit.at
--- tests/lt_dlexit.at  25 Mar 2007 12:12:43 -0000      1.7
+++ tests/lt_dlexit.at  12 Jan 2008 11:20:39 -0000
@@ -1,6 +1,6 @@
 # lt_dlexit.at -- test libltdl functionality                  -*- Autotest -*-
 #
-#   Copyright (C) 2007 Free Software Foundation, Inc.
+#   Copyright (C) 2007, 2008 Free Software Foundation, Inc.
 #   Written by Dave Brolley & Ralf Wildenhues, 2007
 #
 #   This file is part of GNU Libtool.
@@ -134,7 +134,7 @@
 : ${LTDLINCL="-I$abs_top_srcdir/libltdl"}
 : ${LIBLTDL="$abs_builddir/../libltdl/libltdlc.la"}
 
-CPPFLAGS="$CPPFLAGS $LTDLINCL"
+CPPFLAGS="$LTDLINCL $CPPFLAGS"
 LDFLAGS="$LDFLAGS -no-undefined"
 
 for file in a1 b1; do
Index: tests/need_lib_prefix.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/need_lib_prefix.at,v
retrieving revision 1.1
diff -u -r1.1 need_lib_prefix.at
--- tests/need_lib_prefix.at    24 Jun 2007 20:46:47 -0000      1.1
+++ tests/need_lib_prefix.at    12 Jan 2008 11:20:39 -0000
@@ -1,6 +1,6 @@
 # need-lib-prefix.at -- test libltdl functionality            -*- Autotest -*-
 #
-#   Copyright (C) 2007 Free Software Foundation, Inc.
+#   Copyright (C) 2007, 2008 Free Software Foundation, Inc.
 #   Written by Gary V. Vaughan, 2007
 #
 #   This file is part of GNU Libtool.
@@ -139,7 +139,7 @@
 : ${LTDLINCL="-I$abs_top_srcdir/libltdl"}
 : ${LIBLTDL="$abs_builddir/../libltdl/libltdlc.la"}
 
-CPPFLAGS="$CPPFLAGS $LTDLINCL"
+CPPFLAGS="$LTDLINCL $CPPFLAGS"
 LDFLAGS="$LDFLAGS"
 
 # Create our own libtool, forcing need_lib_prefix setting
Index: tests/old-m4-iface.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/old-m4-iface.at,v
retrieving revision 1.11
diff -u -r1.11 old-m4-iface.at
--- tests/old-m4-iface.at       25 Mar 2007 12:12:43 -0000      1.11
+++ tests/old-m4-iface.at       12 Jan 2008 11:20:39 -0000
@@ -1,6 +1,6 @@
 # old-m4-iface.at -- exercise old m4 interface to libtool     -*- Autotest -*-
 #
-#   Copyright (C) 2005 Free Software Foundation, Inc.
+#   Copyright (C) 2005, 2008 Free Software Foundation, Inc.
 #   Written by Gary V. Vaughan, 2005
 #
 #   This file is part of GNU Libtool.
@@ -109,7 +109,7 @@
 AT_DATA([Makefile.in],
 [[top_srcdir   = .
 top_builddir   = .
-COMPILE                = @CC@ @CPPFLAGS@ @INCLTDL@  @CFLAGS@
+COMPILE                = @CC@ @INCLTDL@  @CPPFLAGS@ @CFLAGS@
 LTCOMPILE      = @LIBTOOL@ --mode=compile $(COMPILE)
 LTLINK         = @LIBTOOL@ --mode=link @CC@ -no-undefined @CFLAGS@ @LDFLAGS@ 
-o $@
 SHELL          = @SHELL@