Re: 350-gary-maintain-private-libobj-namespace

[Ralf Wildenhues]

Hi Gary,

I haven't reviewed your last two pending patches yet (but I'm not
telling you to wait for me).  What caught my eyes though at a glance
was this:

* Gary V. Vaughan wrote on Mon, Jan 28, 2008 at 07:38:01PM CET:
>   +++ b/libltdl/m4/ltdl-libobj.m4
[...]
>   +
>   +# Like AC_LIBSOURCES, except the directory where the source file is
>   +# expected is separated from the user LIBOBJ directory.
>   +AC_DEFUN([_LT_LIBSOURCES], [
>   +  m4_foreach([_LTNAME], [$1], [
>   +    m4_syscmd([test -r libltdl/]_LTNAME[ || test ! -d libltdl/])dnl
>   +    m4_if(m4_sysval, [0], [],
>   +      [AC_FATAL([missing libltdl/]_LTNAME)])
>   +  ])
>   +])
[...]

>   +++ b/libtoolize.m4sh
[...]
>   +# func_fixup_ltdl_libobj srcdir destdir
>   +func_fixup_ltdl_libobj ()
>   +{
>   +    $opt_debug
>   +    my_filename=ltdl-libobj.m4
>   +    my_srcdir="$1"
>   +    my_destdir="$2"
>   +    my_fixup_script="s,libltdl/,$ltdldir/,g"
>   +
>   +    $RM "$my_destdir/$my_filename" 2>/dev/null
>   +    if $opt_dry_run; then :;
>   +    else
>   +      $SED "$my_fixup_script" \
>   +        < "$my_srcdir/$my_filename" > "$my_destdir/$my_filename" ||
>   +        func_fatal_error "cannot create $my_destdir/$my_filename"
>   +    fi
>   +}

Changing a m4 file seems very brittle to me.  These files like to get
installed into /usr/share/aclocal, where aclocal can find them even if
you don't want to (and thus if you forget to -I ltdl/m4, you're screwed).
Isn't the real name of the libltdl subdirectory name known at autoconf
time anyway?  (This is an honest, not a rhetorical question; I haven't
checked.)

Probably a good idea to test the libtoolize changes using a ksh.

Thanks,
Ralf