Re: FYI: 353-gary-argz-ac-check-funcs.patch

[Gary V. Vaughan]

Hallo Ralf,

On 1 Mar 2008, at 02:36, Ralf Wildenhues wrote:
> Hi Gary,
>
> On Fri, Feb 29, 2008 at 04:36:17PM -0500, Gary V. Vaughan wrote:
> > Applied to HEAD.
> >
> >  Index: ChangeLog
> >  from  Gary V. Vaughan  <address@hidden>
> >
> >  	* libltdl/m4/argz.m4 (AC_CHECK_FUNCS): Also use our replacement  
> > argz
> if the system argz_add or argz_count are missing.
> >         Report by Juan Manuel Guerrero <address@hidden>.
>
> Why is this patch necessary?  You don't use the result of the tests  
> anywhere.


Strictly it isn't necessary.  Before the patch argz.m4 checked whether  
any of
the argz functions required by libltdl were missing and used our  
replacement
implementation if the system provided only some of the argz api except  
for one
of the functions we need.

Now that our argz is a gnulib module, and used in texinfo builds which  
added
two more missing functions from the full argz api, I added checks for  
those
functions into argz.m4 too mainly for consistency, and arguably  
because some
windows posixy layer might have a partial implementation of argz  
(maybe taken
from an old libtool?) that doesn't provide the argz calls texinfo needs.

The correct approach is to implement the entire argz api in gnulib,  
and find
a better test to decide whether the system argz is useable.  Maybe  
I'll work
on that after libtool-2.2.

Cheers,
        Gary
--
  ())_.              Email me: address@hidden
  ( '/           Read my blog: http://blog.azazil.net
  / )=         ...and my book: http://sources.redhat.com/autobook
`(_~)_

PGP.sig
Description: This is a digitally signed message part