libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Libtool HEAD on Windows.


From: Ralf Wildenhues
Subject: Re: Libtool HEAD on Windows.
Date: Mon, 3 Mar 2008 09:43:23 +0100
User-agent: Mutt/1.5.17 (2008-02-27)

* Duft Markus wrote on Mon, Mar 03, 2008 at 09:33:44AM CET:
> >> 
> >> Attached is both a log for configure/build and the complete
> >> testsuite, and a patch against current HEAD.
> > 
> > Has anybody looked into this yet? I'm afraid this won't apply anymore
> > when it's finally reviewed.
> 
> Just a comment would have been cool, and if it's something like "we
> don't have time right now". However this patch is fairly easy to review
> i think, since nearly every change is inside a case for winnt...
> 
> Still waiting for _something_...

Sorry about being completely silent.  Your patch is intrusive in that it
changes more than should be necessary, it changes code that should not
be changed.  The ideal is: only libtool.m4 and ltdl.m4 contain system
specifics, all other code is generic.  Now I know that we're far from
this ideal, but every step further away is one that should be
scrutinized.

Also, some of the testsuite changes look like they are papering over the
failure rather than fix the issue.  The template.at changes fall into
this category.

Last but not least, I don't know if you noticed that Libtool was in
regression fixes mode up to the 2.2 release (yeah, I know it was an ugly
long time).  Given limited time, I for one simply ignored everything
that wasn't fixing a regression or easy to verify as safe.

I might give a detailed review on your patch, but that may be some days.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]