Re: [patch] quote language related variables in case they have garbage

[Mike Frysinger]

On Sunday 16 March 2008, Ralf Wildenhues wrote:
> * Mike Frysinger wrote on Sun, Mar 16, 2008 at 08:57:25AM CET:
> > On Sunday 16 March 2008, Ralf Wildenhues wrote:
> > > * Mike Frysinger wrote on Sun, Mar 16, 2008 at 08:36:20AM CET:
> > > > if you set a language variable with quotes or semicolons or other
> > > > weird things, you may get ugly warnings/errors when indirectly
> > > > evaluating them.
> > >
> > > Please provide an example, including all output, that exposes this.
> > > I can't see what case it would fix.
> >
> > i did say a language variable set oddly ...
> >
> > tar xf libtool-1.5.26.tar.bz2
> > cd libtool-1.5.26
> > export LANGUAGE='a;b;c'
> > ./configure && make
> > <things quickly fall apart>
>
> Ah, ok, thanks.  But your fix isn't right.  If LANGUAGE contains double
> quotes, then your fix will still do the wrong thing.
>
> I've applied this instead, which should fix things for good in HEAD,
> and put you in THANKS. 

thanks

> Do you care about a brackport to branch-1-5? 

i didnt think anymore 1.5.x releases were being made ... but no, doesnt really 
matter to me.  i dont think there's any valid values those variables could 
have which would cause a problem ...
-mike

signature.asc
Description: This is a digitally signed message part.