Re: [PATCH 370 bis] Implement lt_dlopening of only preloaded modules.

[Gary V. Vaughan]

On 16 Aug 2008, at 17:25, Ralf Wildenhues wrote:

> Hi Gary,

Hallo Ralf,

> late

;o)

> second round of review:
>
> > +         archive_name = MALLOC (char, LT_STRLEN (name) + 3);
>
> This should probably be
>  LT_STRLEN (name) + LT_STRLEN (".a") + 1
>
> except that...
>
> > -         if (tryall_dlopen (&newhandle, attempt, advise, vtable) == 0)
> > +         /* Preloaded modules are always named according to their old
> > +            archive name.  */
> > +         sprintf (archive_name, "%s.a", name);
>
> ... the archive name could also be NAME.lib.

Oi.  Missed that..

> The testsuite addition should ideally also ensure that a non-preloaded
> module cannot be opened with the preload flag set, no?

That seems reasonable.

> None of these issues are regressions.
>
> Please indicate (soon!) whether you will have any resources to work on
> this.  Otherwise I probably can, but I'd like to avoid stepping on  
> your
> toe or doing extra work.

I have very little spare time at the moment, so if you are able to fix  
things before I find the time, that would be very welcome.  If I do  
start to work on it soon, I'll check back in with you first...  thanks.

> Cheers,
> Ralf

Cheers,
        Gary

PGP.sig
Description: This is a digitally signed message part