Re: [patch #6448] [MSVC 7/7] Add MSVC Support

[Peter Rosin]

Markus Duft skrev:
> Could this break parity support? I know It's not in the tree yet, but I
> still hope, that ralf comes to looking into my patch some day....

Hi Markus,

Looking at your patch, the changes to ltmain.m4sh should not have any
special casing for $CC matching *parity* or $host matching *winnt*. I
know that the first hunk just piggybacks on older such code, but new
code should forward a control variable from libtool.m4 instead.
Check e.g. these patches [1] [2] for how to create such variables.

It's not unlikely that there are more issues with your patch, but
that's something to start with, in case you have spare time (yeah,
right...)

Also, your changes to tests/duplicate_conv.at is (or, to be correct,
"will probably be") addressed by setting reload_cmds to false (patch
pending on libtool-patches@). Hold on! This is exactly what was
discussed in this very thread. You should definitely set reload_cmds
to false for Parity as well. You even say this in your ChangeLog:
"Disable the use of reloadable objects (not supported)."

Your changes to the following files should be obsoleted by patches
already in the pr-msvc-support branch:
tests/export.at
tests/link-order.at
tests/stresstest.at

I find it strange that you tie $host matching *winnt* to
Parity/MSVC. That seems to be different from the intentions of
$host ($host is to me a system type, not a toolchain). I would
argue that for Parity, $build should be *-interix* (since
you are using Interix to drive the scripts, IIUC), and $host
should be *-mingw*. I.e. what you are really doing is something
that is in fact cross-compilation (with the quirk that you
happen to be able to run the resulting binaries of course).
But - and that's a big but - I'm in no way an expert on these
issues. And I haven't read up on what Parity is really doing,
so if the dlls etc that pop out are not usable by anything but
Parity it might be a totally different matter.

Cheers,
Peter

[1]http://git.savannah.gnu.org/gitweb/?p=libtool.git;a=commitdiff;h=75220caf33f6635e80cc2b540a75d58bf0e00d46
[2]http://git.savannah.gnu.org/gitweb/?p=libtool.git;a=commitdiff;h=92e15986a43a8009decffc4d5d290272449487a4