[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Handle -o w/ and w/o $EXEEXT during manifest embedding
From: |
Peter Rosin |
Subject: |
Re: Handle -o w/ and w/o $EXEEXT during manifest embedding |
Date: |
Sun, 31 Aug 2008 09:11:51 +0200 |
User-agent: |
Thunderbird 2.0.0.16 (Windows/20080708) |
Den 2008-08-31 07:29, skrev Ralf Wildenhues:
Hi Peter,
thank you for starting a new thread on this. The other, monster thread,
scares me a bit too much for wanting to dig through it.
Should I repost the pending patches as new fresh individual
messages?
* Peter Rosin wrote on Sat, Aug 30, 2008 at 10:26:45PM CEST:
During my exercise with libsndfile I found a problem with
the manifest embedding code. $output may or may not contain
the trailing $EXEEXT, so the code in $postlink_cmds has
to handle both cases (or some c14n has to be added to ltmain).
Is this really a problem with the libtool variable exeext not being set
correctly, or with the libtool script being passed '-o prog' vs. '-o
prog.exe'?
The patch solves the latter, i.e. '-o prog' vs. '-o prog.exe'. I
have not seen any problem with exeext not being correct.
If it's a problem with exeext not being set correctly, then shouldn't we
fix that? Markus Duft posted a patch for that on this list before,
which I've never found the time to evaluate.
Also, this needs testsuite exposure if not already done.
By "this", I assume you mean a check if both '-o prog' and
"-o prog$EXEEXT" work? Should that test do what is needed to
expose a failure to embed the manifest? I.e. do you want the
test to install both progs and then try to run them?
Cheers,
Peter