Re: [PATCH 6/6] use print or printf or cat as $ECHO (really)

[Ralf Wildenhues]

Hi Paolo,

* Paolo Bonzini wrote on Mon, Nov 10, 2008 at 09:58:32PM CET:
> 
> 
> > Regarding the 6/6 patch, you have posted several variants, also there
> > are pending issues.  For me it'd be easiest to review the final one
> > when things have been hashed out; I think I've voiced all concerns that
> > I could find, glancing at the variants.
> 
> The final one is the one you replied to.

Patch is OK with this squashed in.  No ChangeLog entry changes needed,
except please wrap after column 72.

Thanks,
Ralf

diff --git a/HACKING b/HACKING
index c7efe41..3b483f3 100644
--- a/HACKING
+++ b/HACKING
@@ -293,7 +293,7 @@ yyyy-mm-dd  Name of Author  <address@hidden>  (tiny change)
    echo
    print -r
    printf %s\n
-   $CONFIG_SHELL $0 --fallback-echo
+   func_fallback_echo
   it may not have more than one argument, its value may not be eval'ed
   and the argument may not start with a `-'.  As a rule of thumb, use
    echo ..             for literal (constant) strings without leading
diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index 5ace391..e33db52 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -96,9 +96,9 @@ DUALCASE=1; export DUALCASE # for MKS sh
 # A function that is used when there is no print builtin or printf.
 func_fallback_echo ()
 {
-  cat <<_LTECHO_EOF
+  eval 'cat <<_LTECHO_EOF
 $1
-_LTECHO_EOF
+_LTECHO_EOF'
 }
 
 # NLS nuisances: We save the old values to restore during execute mode.
@@ -2356,9 +2356,9 @@ else
 # A function that is used when there is no print builtin or printf.
 func_fallback_echo ()
 {
-  cat <<_LTECHO_EOF
+  eval 'cat <<_LTECHO_EOF
 \$1
-_LTECHO_EOF
+_LTECHO_EOF'
 }
     ECHO=\"$qECHO\"
   fi\
diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4
index 1719901..3e6a2f1 100644
--- a/libltdl/m4/libtool.m4
+++ b/libltdl/m4/libtool.m4
@@ -530,9 +530,9 @@ compiler='$compiler_DEFAULT'
 # A function that is used when there is no print builtin or printf.
 func_fallback_echo ()
 {
-  cat <<_LTECHO_EOF
+  eval 'cat <<_LTECHO_EOF
 \$[]1
-_LTECHO_EOF
+_LTECHO_EOF'
 }
 
 # Quote evaled strings.
@@ -1099,9 +1099,9 @@ else
   # Use this function as a fallback that always works.
   func_fallback_echo ()
   {
-    cat <<_LTECHO_EOF
+    eval 'cat <<_LTECHO_EOF
 $[]1
-_LTECHO_EOF
+_LTECHO_EOF'
   }
   ECHO='func_fallback_echo'
 fi