Re: [PATCH] Fix --verbose option and add new --no-silent option

[Charles Wilson]

Ralf Wildenhues wrote:
> Hi Charles,
> 
> * Charles Wilson wrote on Sat, Nov 15, 2008 at 10:40:26AM CET:
>> * libltdl/config/ltmain.m4sh (usage): Document
>> new --no-silent/--no-quiet options. Spacing changes.
>> (func_enable_tag): Handle --no-silent/--no-quiet options.
>> Modified --verbose to actually activate opt_verbose.
>> New behavior: --silent disables both "normal" output and
>> func_verbose output.  --verbose enables both "normal"
>> output and func_verbose output. --no-silent enables
>> "normal" output, but does not affect func_verbose output.
> 
>> Okay to push?
> 
> This requires a NEWS entry, and libtool.texi update.
> Ideally it should also have a quick functionality test.

Attached, all but functionality test.

--
Chuck


diff --git a/NEWS b/NEWS
index a38bfb3..7bcf44a 100644
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,15 @@ New in 2.2.8 2008-??-??: git version 2.2.7a, Libtool team:
 
   - Libtool ships and installs man pages for libtool and libtoolize now.
   - New libtool command line flag --help-all.
+  - New libtool command line flag --no-silent (with alternate spelling
+    --no-quiet). This flag (re)enables the default informational messages,
+    but has no effect on so-called "verbose" output messages.
+    Ignoring --debug, there are now four different message levels:
+                      normal      verbose
+         (default)      ON          OFF
+         --silent       OFF         OFF
+         --verbose      ON          ON
+         --no-silent    ON       (previous)
 
 * Bug fixes:
 
@@ -13,6 +22,9 @@ New in 2.2.8 2008-??-??: git version 2.2.7a, Libtool team:
     with Autoconf 2.59 (`possibly undefined macro: LT_LIBEXT').
   - Fix 2.2.4 regression that caused arguments with special characters
     to be mangled by the compile wrapper for uninstalled programs on MinGW.
+  - libtool command line flag --verbose now also enables explicit
+    verbose output, in addition to its previous behavior of (re)enabling
+    only the default informational output. See New Features, --no-silent.
 
 * Miscellaneous changes:
 
diff --git a/doc/libtool.texi b/doc/libtool.texi
index f03adfb..15ca80b 100644
--- a/doc/libtool.texi
+++ b/doc/libtool.texi
@@ -1207,7 +1207,46 @@ Do not print out any progress or informational messages.
 
 @item -v
 @itemx --verbose
-Print out progress and informational messages (enabled by default).
+Print out progress and informational messages (enabled by default),
+as well as additional messages not ordinary seen by default.
+
address@hidden --no-quiet
address@hidden --no-silent
+Print out the progress and informational messages that are seen
+by default. This option has no effect on whether the additional
+messages seen in @option{--verbose} mode are shown.
+
+Thus, there are now four different message levels (not counting
address@hidden), depending on whether the normal messages and/or
+the additional verbose messages are displayed.
+
address@hidden @asis
address@hidden @strong{default}
+Normal messages are displayed, verbose messages are not displayed.
+
address@hidden @option{--silent}
address@hidden @option{--quiet}
+Neither normal messages nor verbose messages are displayed.
+
address@hidden @option{-v}
address@hidden @option{--verbose}
+Both normal messages and verbose messages are displayed.
+
address@hidden @option{--no-silent}
address@hidden @option{--no-quiet}
+Normal messages are not displayed, but verbose messages might
+be displayed, depending on whether @option{--verbose} was
+passed as an earlier command line option.
address@hidden table
+
+Thus, to restore the default state, the following two options
+must be given (in order):
address@hidden
address@hidden ... --silent --no-silent ...}
address@hidden example
+The first option @option{--silent} ensures that the verbose messages
+are not displayed, and also disables normal messages. The second
+option @option{--no-silent} (re)enables the normal messages.
 
 @item --version
 Print libtool version information and exit.
diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index db0ea67..bb85ad9 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -40,8 +40,10 @@ m4_divert_push([SCRIPT])# @configure_input@
 #       --mode=MODE          use operation mode MODE
 #       --preserve-dup-deps  don't remove duplicate dependency libraries
 #       --quiet, --silent    don't print informational messages
+#       --no-quiet, --no-silent
+#                            print informational messages (default)
 #       --tag=TAG            use configuration variables from tag TAG
-#   -v, --verbose            print informational messages (default)
+#   -v, --verbose            print more informational messages than default
 #       --version            print version information
 #   -h, --help, --help-all   print short, long, or detailed help message
 #
@@ -319,10 +321,17 @@ func_enable_tag ()
 
       --quiet|--silent)        preserve_args="$preserve_args $opt"
                        opt_silent=:
+                       opt_verbose=false
+                       ;;
+
+      --no-quiet|--no-silent)
+                       preserve_args="$preserve_args $opt"
+                       opt_silent=false
                        ;;
 
       --verbose| -v)   preserve_args="$preserve_args $opt"
                        opt_silent=false
+                       opt_verbose=:
                        ;;
 
       --tag)           test "$#" -eq 0 && func_missing_arg "$opt" && break