Re: [PATCH] Enable runtime cwrapper debugging; add tests

[Charles Wilson]

Charles Wilson wrote:
> Ralf Wildenhues wrote:
>> * Charles Wilson wrote on Mon, Jun 22, 2009 at 03:50:42AM CEST:
>>> * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src)
>>> [ltwrapper_debugprintf]: Renamed to...
>> I think functions should still be put in (parens) in the ChangeLog
>> entry, not in [brackets], according to GCS.
[... other review comments ...]

Okay, here's a followon patch to

"Enable runtime cwrapper debugging; add tests"
http://lists.gnu.org/archive/html/libtool-patches/2009-12/msg00014.html

The first patch, in addition to addressing various points raised in this
thread, obsoletes the "extra" mingw fix:
http://lists.gnu.org/archive/html/libtool-patches/2009-12/msg00017.html

Assuming these two patches are approved, I'll squash them together into
a single commit (and update the commit history) before pushing. I just
figured it was easier to review, by presenting the response to the
review comments separately.

I haven't done a full test run; but I have tested a few of the old tests
and the cwrapper.at tests individually, with this change. Full test run
on both cygwin and linux in progress [*]

This sequence doesn't address the issue with regards to the /shell/
wrapper failing to pass the cwrapper tests (for instance, on linux).
I've got a followon patch to

"Re: [PATCH] Add --lt-* options to shell wrapper"
http://lists.gnu.org/archive/html/libtool-patches/2009-12/msg00015.html

which addresses that issue and will post it shortly, but we should
discuss that in the other thread.

[*] Testing with these two patches, plus the two shell wrapper patches
referenced above, plus the wrapper documentation patch:
http://lists.gnu.org/archive/html/libtool-patches/2009-12/msg00016.html

...
actually, the linux test already finished. Results:
Old: All 94 tests passed
New: Only two unexpected results (in particular, the cwrapper test passed)

 21: passing CXX flags through libtool               FAILED (flags.at:24)
100: Run tests with low max_cmd_len                  FAILED
(cmdline_wrap.at:43)

Err.. 21 should have been skipped, because I haven't installed g++ on
the linux box yet. And 100 is just a repeat of 21.





--
Chuck

update-cwrapper.chg
Description: Text document

update-cwrapper.patch
Description: Text Data