[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactiv
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive. |
Date: |
Sat, 2 Oct 2010 08:11:22 +0200 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
Hi Peter,
* Peter Rosin wrote on Wed, Sep 29, 2010 at 11:21:11PM CEST:
> Den 2010-09-29 21:01 skrev Ralf Wildenhues:
> > * Peter Rosin wrote on Wed, Sep 29, 2010 at 10:06:00AM CEST:
> >> Ok to push this one?
> >
> > I don't mind it, but I'll note that the patch will cause testsuite
> > failures when no wrapper is actually used. This can happen
> >
> > - with --disable-shared passed toplevel, or on static-only systems,
> > - on systems where a wrapper is not needed even in shared mode
> >
> > At least for lalib-syntax it will thus cause failure for the wrong
> > reason (the current XFAIL hides that I guess).
>
> I think you are wrong here.
Well, all the better then, both because that means the situation is
better than feared, and because you're not letting yourself get
distracted.
> lalib-syntax only looks at the 1st argument so the fact that I
> have added a 2nd argument should not matter in practice. We don't
> call it without arguments so its "argc < 2" check is just cosmetics.
>
> > For demo-relink that is irrelevant, as demo/main.c ignores its
> > arguments, tests/depdemo/main.c however also uses them.
>
> The only prior argument to depdemo/main.c that I could find was -alt,
> which is explicitly tested for in main(), so if an extra --lt- option
> "bleeds in", it should be ignored and not cause any harm. I might
> have missed something though.
>
> So, I actually don't think the patch will affect the testsuite results.
OK good.
> > Hmm, --lt-no-interactive instead of --lt-no-popup, for consistency with
> > check-(non)interactive?
>
> --lt-no-interactive is fine by me, but why not --lt-non-interactive?
Hmm. Was thinking about how GCC does options, I guess, with -ffoo
mapped to -fno-foo. no-interactive sounds weirder when spoken out,
though.
> I'll think some more about the general issue. What I really would
> like is a bash shopt to set the error mode from the shell when
> running testsuites. Then we could really forget this issue. Either
> that or some way to make MSYS not force the "default" error mode so
> hard. I have tried to start MSYS with an inherited error mode, but
> I couldn't make it stick. I guess I need to start digging in the
> sources of those projects, and see if I can see what would be the
> best/easiest solution.
That would indeed be cool. IIUC your followup post shows this isn't so
easy though. So feel free to go ahead with the change.
Thanks,
Ralf
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH] tests: don't use assert/abort on MSVC as they are interactive.,
Ralf Wildenhues <=