Re: bindir.at takes forever.

[Ralf Wildenhues]

* Peter Rosin wrote on Thu, Oct 14, 2010 at 11:32:20PM CEST:
> Den 2010-10-14 21:48 skrev Ralf Wildenhues:
> > Changes over the previous patch version:
> > - removed some loop iterations in the inner test, for efficiency, to
> >   address Peter's report,
> > - correctly SKIP the test if tempdir creation fails.
> > 
> > OK to commit both patches?
> 
> Thanks for doing this!  I have one minor nit with these patches which
> I have included inline.  Other than that, the patches seem to cut the
> test time in about half.  Still long, but this shaves off many minutes.
> 
> BTW, the bindir tests still pass on MSYS/MSVC.

Cool, thanks for the review.  I have squashed in this incremental diff
before pushing.

Cheers,
Ralf

diff --git a/ChangeLog b/ChangeLog
index 379e609..b071b92 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -9,7 +9,7 @@
        require a major version number in the $libdir file name, for AIX
        without runtimelinking.  If tmpdir creation fails, skip the
        test.  Use fewer bindir directory names for testing, to speed
-       up the test.
+       up the test.  Also mention MSVC style DLL name in comment.
        Report by Peter Rosin.
 
        tests: remove unneeded 'bindir compile check' test.
diff --git a/tests/bindir.at b/tests/bindir.at
index 3fa185c..4e2fecc 100644
--- a/tests/bindir.at
+++ b/tests/bindir.at
@@ -271,10 +271,10 @@ do
   AT_CHECK([$LIBTOOL --mode=install $lt_INSTALL libfoo.la $libdir], [], 
[ignore], [ignore])
   AT_CHECK([$LIBTOOL --mode=install $lt_INSTALL main$EXEEXT 
$curdir/sbin/main$EXEEXT], [], [ignore], [ignore])
 
-  # And ensure it went where we expect.  Could be looking for any of 
'cygfoo-0.dll',
-  # 'libfoo-0.dll', or 'libfoo.so.0'.  We'll simplify this check by taking 
advantage
-  # of the fact that if it's a DLL, it has to go in bindir, so we'll not check 
for
-  # both forms in libdir.
+  # And ensure it went where we expect.  Could be looking for any of
+  # 'cygfoo-0.dll', 'libfoo-0.dll', 'foo-0.dll', or 'libfoo.so.0'.  We'll
+  # simplify this check by taking advantage of the fact that if it's a DLL,
+  # it has to go in bindir, so we'll not check for both forms in libdir.
   if $bindirneeded; then
     AT_CHECK([test -f $libdir/../bin/???foo-0.dll || ls 
$libdir/../bin/*foo*0*], [], [ignore], [ignore])
   else