[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2] m4: Fix interpretation of MACOSX_DEPLOYMENT_TARGET
From: |
Lawrence Velázquez |
Subject: |
[PATCH v2] m4: Fix interpretation of MACOSX_DEPLOYMENT_TARGET |
Date: |
Sat, 13 Sep 2014 13:29:17 -0400 |
The current template mistakenly treats a MACOSX_DEPLOYMENT_TARGET value
of "10.10" as "10.1" followed by junk. Thinking that the build is
targeting 10.1 Puma instead of 10.10 Yosemite, it tells the linker to
ignore undefined symbols instead of dynamically resolving them. This can
cause runtime crashes* and will affect subsequent versions of OS X.
* https://trac.macports.org/ticket/44596
Signed-off-by: Lawrence Velázquez <address@hidden>
---
v2: Fixed a typo in the original commit message.
m4/libtool.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 320d8b3..068f0d8 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -1043,7 +1043,7 @@ _LT_EOF
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[[91]]*)
_lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;;
- 10.[[012]]*)
+ 10.[[012]][[,.]]*)
_lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined
${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;;
--
2.1.0