libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] testsuite: fix race conditions in ltdl dryrun


From: Pavel Raiskup
Subject: [PATCH] testsuite: fix race conditions in ltdl dryrun
Date: Mon, 15 Dec 2014 14:13:27 +0100
User-agent: KMail/4.14.3 (Linux/3.17.6-200.fc20.x86_64; KDE/4.14.3; x86_64; ; )

[+cc autoconf, as this seems to be relevant]

Hi all,

after several random [ltdl dryrun] failures, I used the 'make --debug' and
some stat calls to debug.  Logs are attached for ok & failed runs as
tarball.  Seems like after 'aclocal' run there should be an explicit
'sleep 1', similarly like in autoreconf [1].  Possible fix attached.  The
problem seems to be in autoheader and Perl's move function (underlying
utime() handling?):

   $ touch /tmp/a
   $ stat /tmp/a
     File: ‘/tmp/a’
     Size: 0               Blocks: 0          IO Block: 4096   regular empty 
file
   Device: 23h/35d Inode: 1296845     Links: 1
   Access: (0664/-rw-rw-r--)  Uid: ( 1000/praiskup)   Gid: ( 1000/praiskup)
   Context: unconfined_u:object_r:user_tmp_t:s0
   Access: 2014-12-15 14:03:35.744530946 +0100
   Modify: 2014-12-15 14:03:35.744530946 +0100
   Change: 2014-12-15 14:03:35.744530946 +0100
    Birth: -
   $ perl -MFile::Copy -e 'move ("/tmp/a", "a");'
   $ stat a
     File: ‘a’
     Size: 0               Blocks: 0          IO Block: 4096   regular empty 
file
   Device: fd00h/64768d    Inode: 11068678    Links: 1
   Access: (0664/-rw-rw-r--)  Uid: ( 1000/praiskup)   Gid: ( 1000/praiskup)
   Context: unconfined_u:object_r:user_home_t:s0
   Access: 2014-12-15 14:03:42.000000000 +0100
   Modify: 2014-12-15 14:03:35.000000000 +0100
                               ^^^ floor()-ed
   Change: 2014-12-15 14:03:42.678581581 +0100
    Birth: -

[1] http://git.savannah.gnu.org/cgit/autoconf.git/tree/bin/autoreconf.in#n356

Pavel

Attachment: racy-tests.tar.gz
Description: application/compressed-tar

Attachment: 0001-tests-fix-race-in-aclocal-autoheader-calls.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]