Re: [libunwind] _ReadSLEB and _ReadULEB

[Matthieu Delahaye]

(Matthias Klose is CCed)

Btw, does this affect /lib/libunwind7.so provided by libgcc1?


Matthieu

On Mon, 2005-02-21 at 13:38, Matthieu Delahaye wrote:
> > Matthieu: what should we do about the Debian packages?  Perhaps it's
> > best if I wait for another week or so and if nothing else shows up
> > release this as 0.98.4?
> > 
> >     --david
> > 
> I would prefer to upload soon. You never know when Sarge will be
> released... 
> 
> If you prefer to wait, I can re-upload a 0.98.3 patched and then you can
> wait on your side before releasing 0.98.4
> 
> > # This is a BitKeeper generated diff -Nru style patch.
> > #
> > # ChangeSet
> > #   2005/02/18 22:15:20-08:00 address@hidden 
> > #   (_ReadSLEB): Fix typo.
> > # 
> > # src/mi/_ReadSLEB.c
> > #   2005/02/18 22:15:19-08:00 address@hidden +1 -1
> > #   (_ReadSLEB): Fix typo: shift needs to be increment before checking
> > #           for loop-exit.  Otherwise, sign-extension may clobber the
> > #           most recently read 7 bits.
> > # 
> > diff -Nru a/src/mi/_ReadSLEB.c b/src/mi/_ReadSLEB.c
> > --- a/src/mi/_ReadSLEB.c    2005-02-18 22:16:46 -08:00
> > +++ b/src/mi/_ReadSLEB.c    2005-02-18 22:16:46 -08:00
> > @@ -11,9 +11,9 @@
> >      {
> >        byte = *bp++;
> >        result |= (byte & 0x7f) << shift;
> > +      shift += 7;
> >        if ((byte & 0x80) == 0)
> >     break;
> > -      shift += 7;
> >      }
> >  
> >    if (shift < 8 * sizeof (unw_word_t) && (byte & 0x40) != 0)
> > _______________________________________________
> > libunwind mailing list
> > address@hidden
> > http://www.hpl.hp.com/hosted/linux/mail-archives/libunwind/
> 
> _______________________________________________
> libunwind mailing list
> address@hidden
> http://www.hpl.hp.com/hosted/linux/mail-archives/libunwind/