Re: [Libunwind-devel] [PATCH 4/4] Add support for multiple threads in core files

[Arun Sharma]

I pushed this patch series with some whitespace cleanup to the github
branch. Please use 2 spaces instead of tabs like the rest of the code.

On Fri, Mar 23, 2012 at 1:00 PM, Alexander Larsson <address@hidden> wrote:

> +           /* Count number of threads */
> +           n_threads = 0;
> +           p = ui->note_phdr;
> +           while (p + sizeof (Elf32_Nhdr) <= note_end)
>              {

The two while loops look redundant. May be write a for_each() type
macro to eliminate redundant code.

> -               ui->prstatus = (void*) ((((long)note_hdr + sizeof(*note_hdr) 
> + note_hdr->n_namesz) + 3) & ~3L);

And use a ALIGN() macro instead of the explicit arithmetic here.

 -Arun