[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] [PATCH 05/11] build: make libunwind-coredump build
From: |
Mike Frysinger |
Subject: |
Re: [Libunwind-devel] [PATCH 05/11] build: make libunwind-coredump build optional |
Date: |
Mon, 10 Sep 2012 21:29:47 -0400 |
On Mon, Sep 10, 2012 at 8:21 PM, Cody P Schafer wrote:
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
>
> EXTRA_DIST = run-ia64-test-dyn1 run-ptrace-mapper run-ptrace-misc \
> - run-check-namespace run-coredump-unwind \
> - run-coredump-unwind-mdi check-namespace.sh.in \
> + run-check-namespace \
> + check-namespace.sh.in \
> Gtest-nomalloc.c Gtest-nocalloc.c
> +if BUILD_COREDUMP
> + EXTRA_DIST += run-coredump-unwind-mdi run-coredump-unwind
> +endif
i don't think EXTRA_DIST should be conditionalized. it's what goes
into the tarball made by `make dist`, and that should always be the
same regardless of `./configure` options.
-mike
[Libunwind-devel] [PATCH 11/11] UPT: Add reg offsets for ppc32/64, Cody P Schafer, 2012/09/10