Re: [Libunwind-devel] [PATCH 10/11] configure: introduce AX_ARG_ENABLE.

[Cody P Schafer]

Whoops, missed the list. Resending.

On 09/10/2012 06:11 PM, Mike Frysinger wrote:
> On Mon, Sep 10, 2012 at 8:21 PM, Cody P Schafer wrote:
> > +# AX_ARG_ENABLE(argument, help-text, if-not-present)
>
> dnl rather than #
>
> > +AC_DEFUN([AX_ARG_ENABLE],
>
> AX_* is sort of a reserved namespace as the large autoconf-archive
> project utilizes it everywhere.  maybe pick a different prefix ?

Sure, any suggestion?

> > +        [AC_ARG_ENABLE([$1], [$2],[enable_$1=$enablearg],[$3])])
>
> this 3rd arg is redundant.  that's pretty much what autoconf already
> does.  i would just omit it.
>
> $ cat configure.ac; autoconf
> AC_INIT(foo)
> AC_ARG_ENABLE(foo, boo, , enable_foo=foo)
> echo $enable_foo
> AC_OUTPUT
> $ ./configure
> foo
> $ ./configure --enable-foo
> yes
> $ ./configure --disable-foo
> no
> -mike

Ah, cool. Will do. Hadn't realized that I could just omit an arg.

In that case, it may be better to just use that pattern in configure.in
(remove the arg) instead of defining a new macro.