[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Libunwind-devel] [PATCH 28/35] Call snprintf() from signal handler only
From: |
Tommi Rantala |
Subject: |
[Libunwind-devel] [PATCH 28/35] Call snprintf() from signal handler only if required in test-async-sig |
Date: |
Tue, 18 Sep 2012 16:31:37 +0300 |
snprintf() is not guaranteed to be safely callable from a signal
handler, so avoid calling it in the default non-verbose case.
---
tests/test-async-sig.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/test-async-sig.c b/tests/test-async-sig.c
index ba37c90..9a0d39e 100644
--- a/tests/test-async-sig.c
+++ b/tests/test-async-sig.c
@@ -89,7 +89,8 @@ do_backtrace (int may_print, int get_proc_name)
buf[0] = '\0';
if (get_proc_name || (may_print && verbose))
{
- if (unw_get_proc_name (&cursor, name, sizeof (name), &off) == 0)
+ ret = unw_get_proc_name (&cursor, name, sizeof (name), &off);
+ if (ret == 0 && (may_print && verbose))
{
if (off)
snprintf (buf, sizeof (buf), "<%s+0x%lx>", name, (long) off);
--
1.7.9.5
- [Libunwind-devel] [PATCH 29/35] Nuke HAVE_BACKTRACE, (continued)
- [Libunwind-devel] [PATCH 29/35] Nuke HAVE_BACKTRACE, Tommi Rantala, 2012/09/18
- [Libunwind-devel] [PATCH 25/35] Rename `rs-race' to `Lrs-race', Tommi Rantala, 2012/09/18
- [Libunwind-devel] [PATCH 26/35] Call `unw_backtrace()' explicitly in test-flush-cache.c, Tommi Rantala, 2012/09/18
- [Libunwind-devel] [PATCH 22/35] Rename `test-varargs' to `Ltest-varargs', Tommi Rantala, 2012/09/18
- [Libunwind-devel] [PATCH 27/35] Roll `test-nocalloc' into `Ltest-nocalloc.c', Tommi Rantala, 2012/09/18
- [Libunwind-devel] [PATCH 32/35] Enable coredump library build on ARM by default, Tommi Rantala, 2012/09/18
- [Libunwind-devel] [PATCH 30/35] Stop including `memory.h', Tommi Rantala, 2012/09/18
- [Libunwind-devel] [PATCH 34/35] ppc32: include `libunwind_i.h' for UNUSED in ucontext_i.h, Tommi Rantala, 2012/09/18
- [Libunwind-devel] [PATCH 33/35] SuperH port, Tommi Rantala, 2012/09/18
- [Libunwind-devel] [PATCH 35/35] ppc32: `UNW_PPC32_REGS' fixlet, Tommi Rantala, 2012/09/18
- [Libunwind-devel] [PATCH 28/35] Call snprintf() from signal handler only if required in test-async-sig,
Tommi Rantala <=
- [Libunwind-devel] [PATCH 31/35] MIPS coredump support, Tommi Rantala, 2012/09/18