[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] [Patch] AArch64 port
From: |
Yvan Roux |
Subject: |
Re: [Libunwind-devel] [Patch] AArch64 port |
Date: |
Thu, 2 May 2013 17:52:03 +0200 |
Hi Arun,
I have to add the Linaro copyright and fix a couple of things before
you push the patch, and I have a question regarding
enable_debug_frame, I enable it for AArch64, but I don't really get
why it is not the default ?
Rq: cxx exceptions are disable for the moment as [GL]test_exc are
failing when I enable them, but will look at it.
Thanks,
Yvan
On 29 April 2013 16:54, Arun Sharma <address@hidden> wrote:
> On Mon, Apr 29, 2013 at 6:38 AM, Yvan Roux <address@hidden> wrote:
>>
>> Hi Arun,
>>
>> Thanks for your review. I looked at the Ltest-nomalloc failures, and
>> the detected malloc calls are made in fopen (called by
>> load_debug_frame in dwarf/Gfind_proc_info-lsb.c) thus, I don't see how
>> to fix this in libunwind.
>
>
> Should be fixable by replacing those calls with open(2). In general, we
> should avoid calling any APIs that are not async signal safe.
>
> -Arun
- Re: [Libunwind-devel] [Patch] AArch64 port,
Yvan Roux <=