Re: [Libunwind-devel] WIP patch: configurable cache size

[Milian Wolff]

Hey Arun,

may I bring this patch to your attention again? Could you please review it or 
accept it upstream?

Thanks

On Friday, September 25, 2015 8:34:09 AM CET Milian Wolff wrote:
> On Montag, 22. Dezember 2014 22:39:29 CEST Arun Sharma wrote:
> > On Thu, Dec 11, 2014 at 7:12 PM, Milian Wolff <address@hidden> wrote:
> > > On Thursday 11 December 2014 13:58:14 Milian Wolff wrote:
> > >> Hey Arun,
> > >> 
> > >> I'm still waiting for your mail you promised below ;-) Locally, I've
> > >> rebased my patch on current master.
> > > 
> > > FTR, attached you find the current state of my patch. Anything
> > > missing/wrong, besides documentation?
> > > 
> > > 
> > > -#define DWARF_LOG_UNW_CACHE_SIZE        7
> > 
> > Why not retain DWARF_LOG_UNW_CACHE_SIZE and use it in a few places
> > that use the constant 7?
> > 
> > The rest of the code looks alright to me. Could you look into the make
> > check failures introduced by the patch? I got 5 new failures.
> 
> Hey Arun,
> 
> there was a serious bug in the last version which was found by the unit
> tests. Should be fixed now \o/
> 
> The problem was that empty caches where handled differently from a NONE
> cache policy, leading to access of invalid pointers. This should be fixed
> now. Additionally, the code is now using the default cache size at a
> central place, and assumes that 0 indicates the default size. If no caching
> is wanted, then one can simply set the policy to none.
> 
> Hope that's good now! There are still some test failures, but I also get
> them in the unpatched master HEAD as of today.
> 
> Bye


-- 
Milian Wolff
address@hidden
http://milianw.de