[Lightning] Re: Stack frame alignment bug on MacOS

[Laurent Michel]

On Jun 10, 2008, at 8:12 PM, Paolo Bonzini wrote:

PS/ My correction aligns on 16 bytes on all architecture. Note that x86_64 requires 16 bytes alignment anyway, so this "wastes" a little bit of space only on Linux i386 and nowhere else. In my case, I don't consider the 12 bytes anything I would loose sleep over, but that's your call.

Can you try this patch instead?  (And maybe you have a testcase to include?...)  If it works, feel free to write a ChangeLog and push it.

PPS/ I can push the changes to git if you wish but I won't until you say it's ok (don't even know if i have write privileges).

I think so.  You had CVS, so you can access git too.

Thanks Paolo. 

I'll try the patch for sure and will commit once I confirm everything's fine.  For the testcase, these are the comet programs I write :-(. I'll try to extract the essence of the test to make a standalone version though. I have ~300 (COMET)programs in my testsuite and right now many appear to be broken when I enable the JIT. I guess that one or two issues can wreak havoc. I'll work on those issues in the next couple of days. My objective is to get back to a fully functional code base with the head version from git in 32bit mode. Once that is done, I'll attack the x86_64 (that was the plan from the beginning). So chances are I'll send a few more emails ;-)

Did you get my message regarding how to cleanly compile the 64 bit version on MacOS? I had to hack a little to get it going, but I am not familiar at all with writing autoconf things, so I was hoping I missed something. 

--

  Laurent

smime.p7s
Description: S/MIME cryptographic signature