Re: [Lilypond-auto] Issue 2934 in lilypond: The bug Context.Grob.property cleanup for \override et al

[lilypond]

Updates:
        Labels: -Patch-countdown Patch-new

Comment #2 on issue 2934 by address@hidden: The bug Context.Grob.property  
cleanup for \override et al
http://code.google.com/p/lilypond/issues/detail?id=2934#c2

Issue 2934: The bug Context.Grob.property cleanup for \override et al

Consisting of the following commits:


Rerun scripts/auxiliar/update-with-convert-ly.sh

This actually required several reverts in a row before rerunning the
script, one for changes to input/regression/alter-broken.ly, and two
for previous runs of update-with-convert-ly.sh.  Of course, afterwards
reapplying the input/regression/alter-broken.ly change...

Squashing several issues would make this easier.

Add more extensive rules for \tweak, \override, \revert, \overrideProperty


Change \overrideProperty to take a single symbol-list as path


Change input/regression/alter-broken.ly to include tweak-like usage

Also change override-like usage for ties to \once\alterBroken as the
control point manipulations are unlikely to be desirable for more than
a single occurence.

Rerun scripts/auxiliar/update-with-convert-ly.sh

Because the version did not change, this required a git revert -n of the
last such run beforehand.

Change \alterBroken interface to match that of other tweak/overrides


Implement function check-grob-path for checking/extending grob path specs

From the function documentation string:

Check a grob path specification @var{path}, a symbol list (or a
single symbol), for validity and possibly complete it.  Returns the
completed specification, or @code{#f} if invalid.  If optional
@var{parser} is given, a syntax error is raised in that case,
optionally using @var{location}.  If an optional keyword argument
@code{#:start @var{start}} is given, the parsing starts at the given
index in the sequence @samp{Context.Grob.property.sub-property...},
with the default of @samp{0} implying the full path.

If there is no valid first element of @var{path} fitting at the given
path location, an optionally given @code{#:default @var{default}} is
used as the respective element instead without checking it for
validity at this position.

The resulting path after possibly prepending @var{default} can be
constrained in length by optional arguments @code{#:min @var{min}} and
@code{#:max @var{max}}, defaulting to @samp{1} and unlimited,
respectively.

http://codereview.appspot.com/6824043