Re: [Lilypond-auto] Issue 3111 in lilypond: Patch: CG: explicitly detail the correct values for git cl config

[lilypond]

Updates:
        Labels: -Type-Enhancement Type-Documentation Fixed_2_17_11

Comment #7 on issue 3111 by address@hidden: Patch: CG: explicitly detail the  
correct values for git cl config
http://code.google.com/p/lilypond/issues/detail?id=3111

When you have done something wrong and you don't know what effects it will  
have on the test infrastructure, rule #1 is: don't fix it.  Just report  
it.  The test infrastructure is able to deal sensibly with single  
mistakes.  Predicting how someone not experienced with it and likely in  
panic will attempt to "fix" such mistakes, however, is not really possible.

Your mistake would have had the consequence of letting the automatic test  
take the resulting master, test it, reporting any resulting problems to the  
developer list and complaining about the problem in the setup.  One could  
then either have pushed to staging the current state of master (like you  
did) or the current state of master plus a revert of the commit when it  
caused problems.

In either case, the faulty commit would have gotten automatic testing (or  
at worst, no testing and a warning to the developer list) and one could  
have reacted on it.  If necessary, by doing a manual test and then  
resynching master and staging.

Whatever else would have happened, the automated test procedures would have  
kept _off_ from pushing anything until the situation had been manually  
corrected.  You failed to tag this issue with Fixed_2_17_11 (according to  
the contents of the VERSION file), and you have marked it  
as "Type-Enhancement" when it is actually Documentation.  I am correcting  
both now, but please try keeping the labels in order yourself in future.